feat(ng-dev/release): implement --stage-only and build cleanup#3767
Open
josephperrott wants to merge 2 commits into
Open
feat(ng-dev/release): implement --stage-only and build cleanup#3767josephperrott wants to merge 2 commits into
josephperrott wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a "stage-only" mode to the release publishing tool, allowing users to run staging steps (bumping versions, generating changelogs, building, and creating a PR) and exit before publishing. This is achieved by adding a --stage-only CLI flag, a new StageOnlySuccessError to signal successful staging, and logic to clean up built package directories. The review feedback suggests optimizing the cleanup process by parallelizing directory deletion with Promise.all and removing a redundant stageOnly property declaration in ReleasePublishOptions since it is already inherited from ReleaseToolFlags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the --stage-only flag for local release staging and automatic build directory cleanup, allowing early exit before publishing.