Skip to content

feat(ng-dev/release): implement publish-ci command and tests#3768

Closed
josephperrott wants to merge 7 commits into
angular:mainfrom
josephperrott:task-2.3-publish-ci-tests
Closed

feat(ng-dev/release): implement publish-ci command and tests#3768
josephperrott wants to merge 7 commits into
angular:mainfrom
josephperrott:task-2.3-publish-ci-tests

Conversation

@josephperrott

Copy link
Copy Markdown
Member

This PR implements the publish-ci command for CI-driven publishing, including monorepo-style tagging support and full unit tests. Stacked on top of the staging CLI changes.

@angular-robot angular-robot Bot added detected: feature PR contains a feature commit target: feature This PR is targeted for a feature branch (outside of main and semver branches) labels Jun 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new command publish-ci and the corresponding PublishCiTool to automate release publishing from CI. It handles git SHA validation, version parsing, release notes generation, GitHub release and tag creation, and publishing to the Wombat registry. Feedback focuses on improving the robustness of the tool: 1) Moving environment variable (WOMBOT_TOKEN) and build artifact validations to the beginning of the execution to fail fast before performing irreversible remote actions. 2) Removing redundant checks once those validations are moved. 3) Enhancing findBuiltPackages with better error handling for missing directories, broken symlinks, or permission issues.

Comment thread ng-dev/release/publish/index-ci.ts
Comment thread ng-dev/release/publish/index-ci.ts Outdated
Comment thread ng-dev/release/publish/index-ci.ts Outdated
Comment thread ng-dev/release/publish/index-ci.ts
@josephperrott josephperrott changed the base branch from task-2.1-stage-only to main June 8, 2026 18:29
@josephperrott

Copy link
Copy Markdown
Member Author

Closing this PR for now to keep the review history clean, as it is dependent on PR #3767. Once PR #3767 is merged, this can be reopened/recreated targeting main.

@josephperrott josephperrott deleted the task-2.3-publish-ci-tests branch June 8, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

detected: feature PR contains a feature commit target: feature This PR is targeted for a feature branch (outside of main and semver branches)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant