Skip to content

Fix implicit null issues for php 8.4#40

Draft
msievenpiper wants to merge 4 commits into
permafrost-dev:mainfrom
msievenpiper:early-php8.4-support
Draft

Fix implicit null issues for php 8.4#40
msievenpiper wants to merge 4 commits into
permafrost-dev:mainfrom
msievenpiper:early-php8.4-support

Conversation

@msievenpiper

Copy link
Copy Markdown
Contributor

Update previously common "implicit" nullable method inputs that are now depricated in php8.4 and future versions.

These changes maintain php7.4 support for the time being but as versions prior to 8.2 are now EoL support for that should be removed at a later stage.

@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.53%. Comparing base (ccdb744) to head (e1ef866).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #40   +/-   ##
=========================================
  Coverage     82.53%   82.53%           
  Complexity      225      225           
=========================================
  Files            49       49           
  Lines           618      618           
=========================================
  Hits            510      510           
  Misses          108      108           
Files with missing lines Coverage Δ
src/Support/VirtualFile.php 92.31% <100.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbbca18...e1ef866. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

… versions 7.4 and <= 8.3 therefore we should omit the comparisons till we remove support for these older versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant