Skip to content

Update CONTRIBUTING.md#2338

Open
bcfletcher wants to merge 1 commit into
pybricks:masterfrom
bcfletcher:patch-1
Open

Update CONTRIBUTING.md#2338
bcfletcher wants to merge 1 commit into
pybricks:masterfrom
bcfletcher:patch-1

Conversation

@bcfletcher

Copy link
Copy Markdown

added language about installing node-canvas

added language about installing node-canvas
@dlech

dlech commented Mar 24, 2025

Copy link
Copy Markdown
Member

Why do we need to install this manually?

@bcfletcher

Copy link
Copy Markdown
Author

I'm a Mac so homebrew isn't installed by default. Nor are any of the requirements to build and compile pybricks.

It took me a while to figure out all the areas to get it to build.

@dlech

dlech commented Mar 24, 2025

Copy link
Copy Markdown
Member

I'm just a bit confused why we need node-canvas though. We don't have to install it on CI to build or test, so why do we have to install it locally?

@bcfletcher

bcfletcher commented Mar 24, 2025 via email

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants