From 2da935195bb810b4c39dcd864b6f827a873fb358 Mon Sep 17 00:00:00 2001 From: Ronan Pigott Date: Mon, 17 Jun 2024 13:26:37 -0700 Subject: [PATCH] gh-111501: Do not export PS1 in venv activate PS1 is a parameter special to the current interactive shell. It does not need to be exported to the environment. Exporting PS1 is not useful, and will break different shells spawned by the current interactive shell. --- Lib/venv/scripts/common/activate | 2 -- .../Tools-Demos/2024-06-17-13-52-04.gh-issue-111501.syFLAV.rst | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) create mode 100644 Misc/NEWS.d/next/Tools-Demos/2024-06-17-13-52-04.gh-issue-111501.syFLAV.rst diff --git a/Lib/venv/scripts/common/activate b/Lib/venv/scripts/common/activate index 241a8650bda33aa..657e4d481f6255a 100644 --- a/Lib/venv/scripts/common/activate +++ b/Lib/venv/scripts/common/activate @@ -21,7 +21,6 @@ deactivate () { if [ -n "${_OLD_VIRTUAL_PS1:-}" ] ; then PS1="${_OLD_VIRTUAL_PS1:-}" - export PS1 unset _OLD_VIRTUAL_PS1 fi @@ -68,7 +67,6 @@ fi if [ -z "${VIRTUAL_ENV_DISABLE_PROMPT:-}" ] ; then _OLD_VIRTUAL_PS1="${PS1:-}" PS1="("__VENV_PROMPT__") ${PS1:-}" - export PS1 fi # Call hash to forget past commands. Without forgetting diff --git a/Misc/NEWS.d/next/Tools-Demos/2024-06-17-13-52-04.gh-issue-111501.syFLAV.rst b/Misc/NEWS.d/next/Tools-Demos/2024-06-17-13-52-04.gh-issue-111501.syFLAV.rst new file mode 100644 index 000000000000000..2989d4b81b1dd39 --- /dev/null +++ b/Misc/NEWS.d/next/Tools-Demos/2024-06-17-13-52-04.gh-issue-111501.syFLAV.rst @@ -0,0 +1 @@ +PS1 is no longer exported by venv activate script