gh-150368: Change Windows user group to secure identifier

[anytokin]

Simmilar to 897bba7

• Issue: icacls fails in tempfile tests on non-english windows distribution #150368

[python-cla-bot]

All commit authors signed the Contributor License Agreement.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[vstinner]

LGTM. But it would be nice if I could reproduce the issue to check the PR: #150368 (comment).

[vstinner]

Lib/test/test_ntpath.py and Lib/test/test_os/test_os.py already call icacls.exe with identifiers instead of names:

Lib/test/test_ntpath.py:            ['icacls.exe', test_file, '/deny', '*S-1-5-32-545:(S)'],
Lib/test/test_os/test_os.py:            ['icacls.exe', fname, '/deny', '*S-1-5-32-545:(S)'],

[zooba]

LGTM with Victor's proposed comment fix.

Not totally sure how far this should be backported, but easy enough to let the bot try and fail.

[chris-eibl]

Approving since I can reproduce the failure on Windows 10 with german settings and the PR fixes it for me.

@anytokin: please sign the Contributor License Agreement, then we can merge.

[vstinner]

Tests / Windows / Build and test (Win32, switch-case) (pull_request): Failing after 12m

FAIL: test_generator_not_under_consumer_arithmetic (test.test_profiling.test_sampling_profiler.test_blocking.TestBlockingModeStackAccuracy.test_generator_not_under_consumer_arithmetic)

That's the unrelated issue gh-150429.

[miss-islington-app]

Thanks @anytokin for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

[bedevere-app]

GH-150701 is a backport of this pull request to the 3.15 branch.

[bedevere-app]

GH-150702 is a backport of this pull request to the 3.14 branch.

[bedevere-app]

GH-150703 is a backport of this pull request to the 3.13 branch.

[vstinner]

Merged. Thanks for fix @anytokin!

[bedevere-bot]

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.15 (tier-1) has failed when building commit 58335ee.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/2019/builds/114) and take a look at the build logs.
4. Check if the failure is related to this commit (58335ee) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/2019/builds/114

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/root/buildarea/3.15.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 948, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>