CI: Add amd64 to NixCI testinfra/build-ami#2193
Open
mmlb wants to merge 5 commits into
Open
Conversation
…stead This way it matches the naming scheme used in packer_template and all throughout ansible files.
Make this package arch agnostic so we can use it in CI and avoid duplicating AMI builds all over the place (later). Next commit will make arch a required arg but this way we get a smaller diff.
PostgreSQL Extension Dependency Analysis: PR #2193
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2193
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
samrose
approved these changes
Jun 8, 2026
Lets make this action support both arches equally which means no more defaults. I decided to swap arch for packer_template because it makes for a better API. I could have parsed the arch from the packer_template file name but I like doing it this way instead better. Note: I changes testinfra-ami-builds's matrix definition slightly. I dropped include in favor of adding another column/variable to the mix. Include is a little weird to think about how sometimes it applies partially vs full while adding a new variable to the matrix is always just the cartesian product which is what we want here anyway.
This way we avoid surprised post merge when running `Release AMI Nix` workflow against both arches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
CI bug fix
What is the current behavior?
NixCI -> ... -> test-ami-nix was only buildling/testing arm64 AMIs leaving amd64 un-built and un-tested so that we would only discover issues after merge.
What is the new behavior?
CI also builds and tests amd64 AMIs.