Skip to content

Symfony 3 support#95

Open
raziel057 wants to merge 2 commits into
BeSimple:masterfrom
raziel057:sf3_support
Open

Symfony 3 support#95
raziel057 wants to merge 2 commits into
BeSimple:masterfrom
raziel057:sf3_support

Conversation

@raziel057

Copy link
Copy Markdown

This PR allow the usage of the bundle with Symfony 3.x and remove dead and buggy code (fixTypeInformation in TypeRepository.php is not used since ServiceDefinition have been renamed Definition).

Important: This commit break the compatibility with Symfony 2.7.x or lower.

@lpalliyaguru

Copy link
Copy Markdown

Hi,
Is there plan to merge this PR ? I am migrating my project to SF3. As such, i cant use any version of the bundle.

@raziel057

Copy link
Copy Markdown
Author

In the meantime, you can use my branch by adding the following configuration in your composer.json

"repositories" : [{
	"type" : "vcs",
	"url" : "https://github.com/raziel057/BeSimpleSoap"
}

My branch adds:

@lpalliyaguru

Copy link
Copy Markdown

@raziel057 , i actually used a fork and your code. It works for me. Thanks for the code!!

@Bomere

Bomere commented Aug 30, 2019

Copy link
Copy Markdown

Hi,
It works for me too!

In addition to adding the repository, I had to modify the version of the package.
"besimple/soap": "dev-sf3_support"

Thanks for the fork!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants