Add smart filters, propagate venue data, and improve timetable filtering performance#170
Open
upayanmazumder wants to merge 7 commits into
Open
Add smart filters, propagate venue data, and improve timetable filtering performance#170upayanmazumder wants to merge 7 commits into
upayanmazumder wants to merge 7 commits into
Conversation
…eping venue + fallback
…ons and constants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces smart filtering capabilities for generated timetables, propagates venue data throughout the application, and includes several performance and maintainability improvements.
Smart Filters
Three toggle-based smart filters have been added to the timetable view to help users narrow down results:
The filter evaluation logic has been extracted into a dedicated module (src/lib/filterUtils.ts) with named constants, eliminating approximately 60 lines of duplicated code that previously existed between the active filter computation and the precomputed match-count logic.
Venue Data
The venue field has been added as an optional property to the timetableDisplayData and fullCourseData types. It is now propagated from subject data through the course selection flow (FacultySelector.tsx), timetable generation (utils.ts), timetable display (ViewTimeTable.tsx), and the compound table component (CompoundTable.tsx). This enables venue-aware filtering and positions the application for future venue display features.
Performance and Correctness
UI Refinements