Skip to content

refactor: allow any token retriever in the rest client#1553

Open
jacob720 wants to merge 1 commit into
mainfrom
service_account_client
Open

refactor: allow any token retriever in the rest client#1553
jacob720 wants to merge 1 commit into
mainfrom
service_account_client

Conversation

@jacob720

Copy link
Copy Markdown

See https://confluence.diamond.ac.uk/pages/viewpage.action?pageId=398853592&spaceKey=DCT&title=04-06-2026
Currently the rest client requires a session manager to handle retrieving auth tokens. I've made it more flexible so that it now accepts anything with a get_valid_access_token method, so a UDC client can use the same rest client.

@jacob720 jacob720 requested a review from a team as a code owner June 10, 2026 13:19
Comment thread src/blueapi/service/authentication.py Dismissed
@jacob720 jacob720 changed the title Don't require a session manager in the rest client refactor: allow any token retriever in the rest client Jun 10, 2026
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.61%. Comparing base (ab2ebc6) to head (8e1d330).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1553   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files          43       43           
  Lines        3214     3215    +1     
=======================================
+ Hits         3073     3074    +1     
  Misses        141      141           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant