feat(events): allow stomp server to handle multiple event sources#1386
Open
JamesDoingStuff wants to merge 1 commit into
Open
feat(events): allow stomp server to handle multiple event sources#1386JamesDoingStuff wants to merge 1 commit into
JamesDoingStuff wants to merge 1 commit into
Conversation
JamesDoingStuff
force-pushed
the
jg/waffle-test-posixuid
branch
from
ce30ebf to
ec4b303
Compare
davehadley
approved these changes
Jun 11, 2026
| self.connection: stomp.Connection | ||
| self.queue = queue.SimpleQueue() | ||
|
|
||
| def create_connection(self, request: generic_pb2.EventSource): |
Collaborator
There was a problem hiding this comment.
suggest to type hint return types.
TBThomas56
reviewed
Jun 11, 2026
Contributor
There was a problem hiding this comment.
Is there a reason why the ClusterWorkflowTemplate is in the templates in events and not in examples? Is this tracked by groups or is it intentionally ignored?
TBThomas56
reviewed
Jun 11, 2026
| workflows.diamond.ac.uk/source: generic | ||
| workflows.diamond.ac.uk/beamline: b01-1 | ||
| spec: | ||
| enabled: true |
Contributor
There was a problem hiding this comment.
would it be worth helm templating the different trigger.enabled values?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AP-1158
Each new connection is stored in a connection manager object, each with its own event queue. This means that a new connection won't overwrite a previous one