Skip to content

fix(dashboard): make targets table scroll on mobile#1346

Merged
christso merged 1 commit into
mainfrom
fix/dashboard-targets-mobile
Jun 10, 2026
Merged

fix(dashboard): make targets table scroll on mobile#1346
christso merged 1 commit into
mainfrom
fix/dashboard-targets-mobile

Conversation

@christso

Copy link
Copy Markdown
Collaborator

Summary

Targets on phone-width Dashboard views no longer hide the right-side metrics behind a clipped table. The Targets summary now uses the same mobile-safe table treatment as existing run detail tables: a stable minimum width inside a horizontal overflow container, so users can scroll from target names through pass rate, eval counts, and execution errors while desktop continues to fill the available width.

Verification

  • cd apps/dashboard && bun run build
  • bun --filter @agentv/dashboard test
  • bunx biome check apps/dashboard/src/components/TargetsTab.tsx
  • bun run verify
  • Visual UAT with local Dashboard from current code via bun apps/cli/src/cli.ts dashboard --port 3128 at /projects/financial-research-agent?tab=targets

Evidence

  • Mobile red case, before fix: /tmp/agentv-evidence/targets-mobile-red.png — columns after Pass Rate are clipped in the non-scrollable table.
  • Mobile green case, after fix: /tmp/agentv-evidence/targets-mobile-green-left.png and /tmp/agentv-evidence/targets-mobile-green-scrolled.png — horizontal scrollbar is visible and the right-side Evals / Execution Errors columns are reachable.
  • Desktop green case: /tmp/agentv-evidence/targets-desktop-green.png — table still fills the desktop content area without horizontal scrolling.

Compound Engineering
Codex

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 10, 2026

Copy link
Copy Markdown

Deploying agentv with  Cloudflare Pages  Cloudflare Pages

Latest commit: b6c6a54
Status: ✅  Deploy successful!
Preview URL: https://60f945c7.agentv.pages.dev
Branch Preview URL: https://fix-dashboard-targets-mobile.agentv.pages.dev

View logs

@christso

Copy link
Copy Markdown
Collaborator Author

Addressed AO review finding from review-run-9249950c-122f-4ee1-86bf-daea599a4a02.

Staged non-result files can be committed during sync

Fixed: results repo auto-sync now only treats canonical writable results trees (.agentv/results/runs/** and .agentv/results/metadata/**) as safe, stages/commits only the inspected safe dirty pathspecs, and uses git commit --only so unrelated staged index entries cannot be swept into the sync commit. Added a regression test that stages .agentv/results/README.md alongside a dirty run and verifies sync blocks without creating a local ahead commit or pushing the note.

Verification:

  • bun test packages/core/test/evaluation/results-repo.test.ts
  • bun --filter @agentv/core typecheck
  • bunx biome check packages/core/src/evaluation/results-repo.ts packages/core/test/evaluation/results-repo.test.ts
  • bun --filter @agentv/core test

@christso

Copy link
Copy Markdown
Collaborator Author

Triage for AO review run review-run-1e1767e4-ef83-48c8-b670-bcf6f1a2d665:

Review could not inspect diff

No code change needed for this reviewer note. I verified the PR branch is still clean and pushed at 37e7bb7e6ca86ecc2ec98e75095f3d94cc25c873; local git status and git diff origin/main...HEAD --stat work in this session. This finding reports a reviewer environment bwrap failure rather than a concrete source issue.

@christso christso force-pushed the fix/dashboard-targets-mobile branch from 37e7bb7 to b6c6a54 Compare June 10, 2026 12:07
@christso

Copy link
Copy Markdown
Collaborator Author

Refreshed PR branch after #1347 merged.

  • Rebased/reset onto current origin/main (da457382).
  • Dropped the already-merged results sync commit from this PR branch.
  • PR diff now contains only apps/dashboard/src/components/TargetsTab.tsx.

Verification rerun after refresh:

  • cd apps/dashboard && bun run build
  • bun --filter @agentv/dashboard test
  • bunx biome check apps/dashboard/src/components/TargetsTab.tsx
  • bun --filter @agentv/core build before local CLI dashboard UAT
  • Force-push hook also ran typecheck + Biome successfully.

UAT evidence from current branch:

  • Mobile left: /tmp/agentv-evidence/targets-mobile-refreshed-left.png
  • Mobile scrolled: /tmp/agentv-evidence/targets-mobile-refreshed-scrolled.png
  • Desktop: /tmp/agentv-evidence/targets-desktop-refreshed.png

@christso christso merged commit 63734ea into main Jun 10, 2026
8 checks passed
@christso christso deleted the fix/dashboard-targets-mobile branch June 10, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant