fix(cli): remove eval export option#1349
Merged
Merged
Conversation
537d08f to
5b690bf
Compare
Deploying agentv with
|
| Latest commit: |
5b690bf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d47941ea.agentv.pages.dev |
| Branch Preview URL: | https://cleanup-remove-eval-export.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentv evalnow has one results boundary: the--outputrun directory and itsindex.jsonlmanifest. The removed--exportpath no longer appears in help or parsing, and former flat-format writers are gone so JSONL/benchmark/timing/transcript/per-test artifacts remain the only eval-run artifact contract.Consumer research
--exportonly in AgentV docs, tests, helper scripts, and the eval CI workflow; all were migrated to--output/index.jsonlor removed."agentv eval" "--export","agentv eval run" "--export", and WiseTechGlobal/EntityProcess scoped variants returned no external hits.gh repo view WiseTechGlobal/sddconfirmed the repo is private; downloaded the accessible zipball and searched it directly. The onlyagentv evalusages were.github/workflows/sdd-eval.ymlandevals/e2e/scripts/check-v2-suite.test.cjs, and neither used--export.Behavior changes
agentv eval run --helpno longer advertises--export.--exportis rejected by the CLI parser as an unknown argument.<run>/index.jsonlfrom the canonical run folder.agentv eval.Red/green CLI evidence
agentv eval run --helplisted--export <str>--exportoption in help--exportinvocation--export /tmp/.../results.jsonland wrote the flat fileUnknown arguments--output /tmp/.../runwroteindex.jsonl,benchmark.json,timing.json,transcript.jsonl--outputremains the canonical complete artifact boundary withindex.jsonl,benchmark.json,timing.json,transcript.jsonl, per-test artifacts, and task bundles.Verification
bun run verifybun run validate:examplesbun test apps/cli/test/eval.integration.test.tsbun apps/cli/src/cli.ts eval ... --dry-run --output /tmp/.../run --export /tmp/.../results.jsonlfails as unknown;--output /tmp/.../runwrites the expected run artifacts.Code review: manual simplification/review completed; subagent-based Tier 2 review was not run because this Codex session's multi-agent tool only permits spawning when the user explicitly asks for sub-agents. The simplification pass removed the now-dead flat-format writer dispatch and tests.
Post-Deploy Monitoring & Validation
No additional operational monitoring required. This removes an unreleased/cleanup CLI option; validation is via CI and user-facing CLI behavior (
agentv eval run --help,agentv eval ... --output <dir>, and rejection of--export).