feat(config): use succinct repo_url project remotes#1357
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
a71eb30
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c3b9c030.agentv.pages.dev |
| Branch Preview URL: | https://feat-1354-repo-url.agentv.pages.dev |
c5cd36a to
a71eb30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1356 for issue #1354. The merged hard-break schema used GitHub owner/name
repositoryfields and derived HTTPS clone URLs. Per follow-up design discussion, this switches Dashboard project/results config to a succinct Git remote schema:This uses
repo_urlfor remote Git transport andpathfor local checkout paths at both levels.Refs #1354; supersedes the
repositoryowner/name shape merged in #1356.Changes
repositoryfields with camelCaserepoUrl; YAML usesrepo_url.repoUrldirectly togit clone, supporting HTTPS/SSH/file-style remotes.results.repo_urlandresults.path.projects[].sourceprojects[].repositoryprojects[].results.modeprojects[].results.repoprojects[].results.repositoryprojects[].results.local_pathprojects[].results.auto_pushrepo_url+path.Red / Green UAT
repositoryand thenresults.local_path, so SSH transport and succinct symmetric path naming were not represented.https://github.com/example/repo.gitandgit@github.com:example/repo.git; source and results local checkouts both usepath.Verification
bun run buildbun test packages/core/test/projects.test.ts packages/core/test/project-sync.test.ts packages/core/test/evaluation/validation/config-validator.test.ts apps/cli/test/commands/results/serve.test.tsgit diff --checkbun run lintbun run typecheckbun run test