Fix sigalg→sign_alg param naming for create_authn_request in POST binding#432
Open
JPDSousa wants to merge 1 commit into
Open
Fix sigalg→sign_alg param naming for create_authn_request in POST binding#432JPDSousa wants to merge 1 commit into
JPDSousa wants to merge 1 commit into
Conversation
JPDSousa
force-pushed
the
joao.sousa/fix-sign_alg-param
branch
from
bb04cd5 to
14cd3ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When signing is enabled and POST binding with a custom template is used, sso_kwargs["sigalg"] was passed directly to client.create_authn_request(), which expects the parameter as "sign_alg". This caused the signing algorithm to be silently ignored (absorbed by **kwargs).
The fix copies sso_kwargs before the create_authn_request call, pops "sigalg", and passes it as "sign_alg". The original sso_kwargs dict remains unchanged for prepare_for_authenticate calls, which correctly expect "sigalg".
Adds a test verifying create_authn_request receives sign_alg (not sigalg).
Fixes #433