Skip to content

Fix tests for dpctl change to return tuples#2945

Open
ndgrigorian wants to merge 2 commits into
masterfrom
fix-tests-for-dpctl-tuple-changes
Open

Fix tests for dpctl change to return tuples#2945
ndgrigorian wants to merge 2 commits into
masterfrom
fix-tests-for-dpctl-tuple-changes

Conversation

@ndgrigorian

Copy link
Copy Markdown
Collaborator

dpctl returns tuples now rather than lists for devices, subdevices, etc. as these should be immutable to users

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

dpctl returns tuples now rather than lists for devices, subdevices, etc. as these should be immutable to users
@ndgrigorian ndgrigorian marked this pull request as ready for review June 9, 2026 20:15
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2945/index.html

@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 78.251% (+0.003%) from 78.248% — fix-tests-for-dpctl-tuple-changes into master

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Array API standard conformance tests for dpnp=0.21.0dev0=py313h509198e_68 ran successfully.
Passed: 1357
Failed: 3
Skipped: 16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants