Skip to content

fix: adaptor map_names calls dict as function when inputs is a name-mapping dict #8907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aymuos15 wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix: adaptor map_names calls dict as function when inputs is a name-mapping dict #8907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccab48d
Fix adaptor map_names calling dict as function
aymuos15 Jun 8, 2026
78ee271
Add regression test for adaptor with **kwargs and dict inputs
aymuos15 Jun 8, 2026
c17fe26
Merge branch 'dev' into fix/adaptors-map-names
aymuos15 Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion monai/transforms/adaptors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def must_be_types(variable_name, variable, types):
raise TypeError(f"'{variable_name}' must be one of {types} but is {type(variable)}")

def map_names(ditems, input_map):
return {input_map(k, k): v for k, v in ditems.items()}
return {input_map.get(k, k): v for k, v in ditems.items()}

def map_only_names(ditems, input_map):
return {v: ditems[k] for k, v in input_map.items()}
Expand Down
9 changes: 9 additions & 0 deletions tests/transforms/test_adaptors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,15 @@ def foo(a):
dres = adaptor(foo, {"a": "b"}, {"b": "a"})(d)
self.assertEqual(dres["b"], 4)

def test_kwargs_with_dict_inputs(self):

def foo(**kwargs):
return {k: v * 2 for k, v in kwargs.items()}

d = {"x": 3}
dres = adaptor(foo, {"out": "out"}, {"x": "out"})(d)
self.assertEqual(dres["out"], 6)


class TestApplyAlias(unittest.TestCase):

Expand Down
Loading