Skip to content

test(install): use tmp_ dirs instead of real lib/deps#696

Merged
Chemaclass merged 1 commit into
mainfrom
test/install-tmp-dirs
Jun 7, 2026
Merged

test(install): use tmp_ dirs instead of real lib/deps#696
Chemaclass merged 1 commit into
mainfrom
test/install-tmp-dirs

Conversation

@Chemaclass
Copy link
Copy Markdown
Member

What

Follow-up to #695. The explicit-directory install tests wrote bashunit into the repo's real lib/ and deps/ folders. Switch them to throwaway tmp_deps / tmp_lib dirs so the suite never touches tracked project directories.

Changes

  • test_install_downloads_in_given_folder: depstmp_deps
  • test_install_downloads_the_given_version: lib 0.9.0tmp_lib 0.9.0
  • test_install_downloads_the_non_stable_beta_version: deps betatmp_deps
  • set_up/tear_down clean up tmp_install / tmp_deps / tmp_lib; dropped the deps/ cleanup.

The two default-behavior tests (./install.sh and ./install.sh <version> with no dir) keep using lib/ on purpose — they assert install.sh's documented default install directory, which can't be relocated without losing that coverage.

Tests

Test-only refactor, no behavior change. Full suite green (1100 passed); make sa + make lint pass; shfmt clean.

The explicit-directory install tests wrote into the repo's real lib/ and deps/
folders. Switch them to throwaway tmp_deps/tmp_lib dirs so tests never touch
tracked project directories. The two default-behavior tests keep using lib/,
since they assert install.sh's documented default install directory.
@Chemaclass Chemaclass added the pure testing Pure testing related label Jun 7, 2026
@Chemaclass Chemaclass self-assigned this Jun 7, 2026
@Chemaclass Chemaclass merged commit 19a0ade into main Jun 7, 2026
31 checks passed
@Chemaclass Chemaclass deleted the test/install-tmp-dirs branch June 7, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pure testing Pure testing related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant