refactor(project): Defer initial build after watchers are ready#1403
Open
matz3 wants to merge 1 commit into
Open
refactor(project): Defer initial build after watchers are ready#1403matz3 wants to merge 1 commit into
matz3 wants to merge 1 commit into
Conversation
Triggering the initial build before initializing the watchers caused the perf logging of build/caching related tasks to be inaccurate as the watchers can delay the build significantly. In context of the improvements via #1400 this will likely not be a problem anymore, but it is still better to have a clear order defined and only start initial builds after the watchers are ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggering the initial build before initializing the watchers caused the perf logging of build/caching related tasks to be inaccurate as the watchers can delay the build significantly.
In context of the improvements via #1400 this will likely not be a problem anymore, but it is still better to have a clear order defined and only start initial builds after the watchers are ready.