E2E test changes for #64952 - Prevent empty Quick Draft submissions from WordPress dashboard#12086
E2E test changes for #64952 - Prevent empty Quick Draft submissions from WordPress dashboard#12086audrasjb wants to merge 5 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Looks like the E2E tests are fixed now. I think the implementation is ready for review. Note for the future committer: don't forget to add the props from the first PR: |
joedolson
left a comment
There was a problem hiding this comment.
Should also add a parallel test verifying that a draft can be created with title but without content. Basically the same thing, just using title content.
|
Right @joedolson 👍 New test added for post with Title but without Content. |
joedolson
left a comment
There was a problem hiding this comment.
The setCustomValidity method doesn't voice errors for screen readers, so while the functionality is good, the error message will need some additional accessibility enhancements.
I think it would probably be better, and more consistent with other experiences in the admin, to use an inline admin notice and wp.a11y.speak() to make the error both more visually integrated and accessible.
|
Thanks for the feedback! |
https://core.trac.wordpress.org/ticket/64952
This copies changes from #11380 and add E2E tests changes.