Skip to content

E2E test changes for #64952 - Prevent empty Quick Draft submissions from WordPress dashboard#12086

Open
audrasjb wants to merge 5 commits into
WordPress:trunkfrom
audrasjb:64952-e2e-tests
Open

E2E test changes for #64952 - Prevent empty Quick Draft submissions from WordPress dashboard#12086
audrasjb wants to merge 5 commits into
WordPress:trunkfrom
audrasjb:64952-e2e-tests

Conversation

@audrasjb

@audrasjb audrasjb commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

https://core.trac.wordpress.org/ticket/64952

This copies changes from #11380 and add E2E tests changes.

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props audrasjb, joedolson.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@audrasjb

audrasjb commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

Looks like the E2E tests are fixed now. I think the implementation is ready for review.
I'm closing the other PR in favor of this one.

Note for the future committer: don't forget to add the props from the first PR: opurockey, westonruter

@joedolson joedolson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also add a parallel test verifying that a draft can be created with title but without content. Basically the same thing, just using title content.

@audrasjb

audrasjb commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

Right @joedolson 👍 New test added for post with Title but without Content.

@audrasjb audrasjb requested a review from joedolson June 4, 2026 13:44

@joedolson joedolson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setCustomValidity method doesn't voice errors for screen readers, so while the functionality is good, the error message will need some additional accessibility enhancements.

I think it would probably be better, and more consistent with other experiences in the admin, to use an inline admin notice and wp.a11y.speak() to make the error both more visually integrated and accessible.

@audrasjb

audrasjb commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants