docs(aria/menu): fix menubar example highlight styling#33290
Conversation
e91435d to
a2dc522
Compare
|
@crisbeto would you be able to take a look at this when you get a chance? Thanks! |
a2dc522 to
e2bd1e4
Compare
|
This seems to me the styling issue for code examples on adev. The |
e2bd1e4 to
7b674e6
Compare
Highlight menubar items only while interacting, using :hover, :focus-within, and [aria-expanded='true'] for the open submenu state. Items inside an open menu keep their [data-active] highlight.
7b674e6 to
f6bab45
Compare
|
You are right, thanks. |
|
FYI angular/angular#69103 updates the menu examples style on adev. Thanks for raising up the issue! |
|
Deployed dev-app for f6bab45 to: https://ng-dev-previews-comp--pr-angular-components-33290-dev-p4l24pi9.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
Summary
Updates the menubar example styles so items highlight only while the user is interacting:
:hover,:focus-within, and[aria-expanded='true'](for when the submenu is open and focus is in the overlay). Items inside an open menu keep their[data-active]highlight.Test plan
pnpm dev-app, Aria Menubar): nothing highlighted at rest, hover/focus highlight the right item, clears on leave.