test(transform): pad the newest-20 skeleton window for the legacy full-drop expectation#138
Open
iceteaSA wants to merge 1 commit into
Open
Conversation
…l-drop expectation Upstream db7bc0a (tool skeletons for newest-20 drops) updated apply-operations.tool-drop.test.ts via padSkeletonWindow but missed this transform-level test, which queues drops on a 2-message session — trivially inside the skeleton window, so the dropped tool now survives as a truncated skeleton and the 'fully dropped' assertion fails on PRISTINE upstream/master too (verified in a clean worktree: v0.23.0 passes 37/37, 4e3635c fails 36/37). Same remediation upstream applied to its own tests: insert 20 newer tool tags so the drop exercises the deep-history full-removal path the test documents.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
iceteaSA has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: test(transform): pad the newest-20 skeleton window for the legacy full-drop expectation
Problem
db7bc0a(feat(ctx-reduce): keep tool skeletons for drops in the newest-20window) changed drop semantics — agent drops of a tool call within the newest
20 tool tags now truncate in place instead of full removal — and updated
apply-operations.tool-drop.test.tsaccordingly via thepadSkeletonWindowhelper. One older test was missed:
transform.test.ts › createTransform › applies pending drop operations when scheduler executesThat test queues drops on a 2-message session, which is trivially inside the
skeleton window, so the dropped tool-only assistant message now survives as a
truncated skeleton and the test's "fully dropped, shell stripped"
expectation (
toHaveLength(1)) fails.Reproduced on pristine
master(4e3635c) in a clean worktree:Fix
Same remediation
db7bc0aapplied to its own file's legacy tests: insert 20newer tool tags before queueing the drops, pushing the real tag out of the
newest-20 skeleton window so the test keeps exercising the deep-history
FULL-removal path its assertions document. No production code touched;
behavior coverage for the new skeleton path already lives in
apply-operations.tool-drop.test.ts.Verification
bun test src/hooks/magic-context/transform.test.ts→ 37 pass / 0 failpackages/pluginsuite → 2082 pass / 0 fail (with this one-file changeon top of master)
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Summary by cubic
Pads the newest-20 skeleton window in
packages/plugin/src/hooks/magic-context/transform.test.tsby inserting 20 tool tags so the test continues to assert full removal for deep-history drops. Fixes the failing test after the tool-skeleton change; no production code changed.Written for commit dc30ca8. Summary will update on new commits.