Skip to content

Updates to cep3 in preparation for releases #339

Open
munkm wants to merge 5 commits into
cyclus:sourcefrom
munkm:cep3-updates
Open

Updates to cep3 in preparation for releases #339
munkm wants to merge 5 commits into
cyclus:sourcefrom
munkm:cep3-updates

Conversation

@munkm

@munkm munkm commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

In preparation for cyclus/cyclus#1685 , we've been looking through the release procedure defined in CEP3. The changes in this PR include:

  • removing references to smbchk.py. It has been deprecated.

I will update this PR description with the other changes as we find them.

@munkm

munkm commented Mar 21, 2024

Copy link
Copy Markdown
Contributor Author

We need to update cep3 in line with cyclus/cyclus#1696.

@dean-krueger

Copy link
Copy Markdown
Contributor

As per issue #338, should references to "master" in this document be changed to "main"?

@munkm

munkm commented Mar 21, 2024

Copy link
Copy Markdown
Contributor Author

@dean-krueger yes we should change everything to main. Would you like to do that?

@munkm

munkm commented Mar 21, 2024

Copy link
Copy Markdown
Contributor Author

CEP3 mentions the releases repository. Do we use this widely? It seems like we might not, because we have a conda-forge feedstock but the conda script seems to predate conda-forge.

@munkm

munkm commented Mar 21, 2024

Copy link
Copy Markdown
Contributor Author

We also need to update cep3 based on the decisions in: cyclus/cyclus#1700

@abachma2 abachma2 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Are there any other changes that need to be made to this CEP before merging? @gonuke?

@munkm

munkm commented Apr 15, 2024

Copy link
Copy Markdown
Contributor Author

I've been going back through this document and have a few questions:

  • Do we want to keep the pyne directions in the maintenance section?
  • Do we want to keep the nuclear data directions in the maintenance section?

@abachma2

Copy link
Copy Markdown
Member

On a previous call, I mentioned that I think the main place that pyne is used is in the decay solver. Is anyone aware if this is true? And thinking about it some, pyne may also be used in Cycamore, with the FuelFab archetype. That might be worth exploring, since Cycamore has Cyclus as a dependency.

@gonuke

gonuke commented Apr 29, 2024

Copy link
Copy Markdown
Member

I think PyNE is used in a few places for compositions, nuclide naming and materials.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants