Rename CLI token storage types to the Store vocabulary#5384
Merged
Conversation
Follow-up to #5383. That PR introduced the CLI-owned Store interface but deliberately left the concrete types and helpers in the old Cache vocabulary to keep the diff focused. This change does the rename it promised. CLI-owned storage pieces move to the Store vocabulary: the backends (fileTokenCache -> fileStore, keyringCache -> keyringStore, and constructors), the resolver (ResolveCache -> ResolveStore, cacheFactories -> storeFactories), the on-disk format types (tokenCacheFile -> tokenStoreFile), and related helpers and test doubles. file_cache.go is renamed to filestore.go. The on-disk filename stays token-cache.json for backward compatibility; only Go identifiers change. Anything that implements or refers to the SDK's TokenCache keeps the Cache name: the ToU2MTokenCache adapter, the DualWritingTokenCache and notFoundHintCache wrappers, the OAuthTokenCache helper, and the test doubles that implement the SDK TokenCache. Co-authored-by: Isaac
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 25b79bb |
simonfaltum
approved these changes
May 31, 2026
Member
simonfaltum
left a comment
simonfaltum
left a comment
There was a problem hiding this comment.
No blocking findings from my pass. Verified locally with go test ./cmd/auth ./libs/auth/... on the PR worktree.
Tiny non-blocking nit: libs/auth/credentials_test.go still mentions storage.ResolveCache in two comments; those can be updated to storage.ResolveStore for consistency, but there is no behavioral impact.
…mments Addresses review nit: two comments in credentials_test.go still referenced storage.ResolveCache. Co-authored-by: Isaac
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
Follow-up to #5383, which introduced the CLI-owned
Storeinterface but deliberately left the concrete types and helpers in the oldCachevocabulary to keep that PR focused on the structural change. This PR does the rename that #5383 promised, so the package reads consistently.Testing
Pure rename, no behavior change. Existing auth unit and acceptance tests pass.