Fix configuration binding for HTTP client logging data classifications#7553
Draft
Marcus-Kanon wants to merge 1 commit into
Draft
Fix configuration binding for HTTP client logging data classifications#7553Marcus-Kanon wants to merge 1 commit into
Marcus-Kanon wants to merge 1 commit into
Conversation
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1456079&view=codecoverage-tab |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes configuration-based registration for extended HTTP client logging when header data classifications are provided from appsettings.json.
The documented configuration shape for RequestHeadersDataClasses and ResponseHeadersDataClasses uses values like "None" and "Unknown", but the configuration path was relying on default binding behavior that does not bind DataClassification correctly in this scenario. This caused startup failures for AddExtendedHttpClientLogging(configurationSection).
This change:
Testing
Fixes #7551