fix(ast): avoid panic in ConstantNode.String on non-JSON floats#974
Open
netliomax25-code wants to merge 1 commit into
Open
fix(ast): avoid panic in ConstantNode.String on non-JSON floats#974netliomax25-code wants to merge 1 commit into
netliomax25-code wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConstantNode.String panics when json.Marshal rejects the value, which happens for NaN and ±Inf. Constant folding produces these for array literals like [0/0], and predicateCombination calls String on the collection argument while optimizing, so any([0/0], # > 0) || any([0/0], # > 0) makes expr.Compile panic instead of returning a program. Compile does not recover, so the panic reaches the host. Fall back to fmt for values json cannot encode.