feat(memory): add RedisMemoryService#157
Open
volkthienpreecha wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the Redis-backed memory service work from google/adk-python#5919 into the community repo after maintainer guidance.
This adds
RedisMemoryServiceundergoogle.adk_community.memory, complementing the existing Redis session service. It keeps the implementation focused on theBaseMemoryServicecontract, stores memory entries in Redis, supports keyword search scoped byapp_nameanduser_id, and filters thought parts before persisting memory text.Tests cover session ingest, event deltas, dedupe, session replacement, user scoping, case-insensitive search, thought filtering, missing timestamps, and client cleanup.
My validation:
58 passed, 13 skipped, 4 warnings. The skipped tests were for optional packages I did not have installed (aioboto3 and sdc_agents), and the warnings were existing ADK deprecation warnings unrelated to this Redis memory change.