fix(evaluation): skip invocations without user events to prevent ValidationError#5929
Open
Oxygen56 wants to merge 2 commits into
Open
fix(evaluation): skip invocations without user events to prevent ValidationError#5929Oxygen56 wants to merge 2 commits into
Oxygen56 wants to merge 2 commits into
Conversation
…dationError Change user_content initialization from Content(parts=[]) to None and skip invocations that have no user-authored events. This prevents ValidationError from semantically incorrect empty Content objects. Fixes google#3760
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
user_contentinitialization fromContent(parts=[])toNoneand skips invocations that have no user-authored events.Previously, internal/system-driven invocations lacking a user event would produce semantically incorrect eval cases with empty content objects, causing a
ValidationError.Changes
user_content = Noneinstead ofContent(parts=[])ValidationErrorfrom empty Content objectsFixes #3760