Skip to content

Update formatter to handle Google email addresses with + signs #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lindsey-volta wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update formatter to handle Google email addresses with + signs #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3452eb
Update formatter to handle Google email addresses with + signs
lindsey-volta Jun 1, 2026
d52d4d6
Update example email addresses
lindsey-volta Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions google/ads/datamanager_util/format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ def format_email_address(self, email: str) -> str:
# "Create variations of your email address" at:
# https://support.google.com/a/users/answer/9282734

# Removes plus sign (+) and all characters that follow it.
user = user.split("+")[0]

# Removes all periods (.).
user = re.sub("\\.", "", user)
if len(user) == 0:
Expand Down
18 changes: 18 additions & 0 deletions tests/formatter_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,24 @@ def test_format_email_address_valid_inputs(self):
"Periods should be stripped from googlemail.com address",
)

self.assertEqual(
Copy link
Copy Markdown
Member

@jradcliff jradcliff Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use example emails from https://developers.google.com/style/examples#example-email-addresses instead?

Copy link
Copy Markdown
Contributor Author

@lindsey-volta lindsey-volta Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use the same sample emails from the documentation.

"cloudysanfrancisco@googlemail.com",
self.formatter.format_email_address("Cloudy.SanFrancisco+shopping@googlemail.com"),
"Plus sign and everything after should be stripped from googlemail.com address",
)

self.assertEqual(
"cloudysanfrancisco@gmail.com",
self.formatter.format_email_address("Cloudy.SanFrancisco+shopping@gmail.com"),
"Plus sign and everything after should be stripped from gmail.com address",
)

self.assertEqual(
"user.name+nyc@example.com",
self.formatter.format_email_address("user.name+NYC@Example.com"),
"Plus sign and everything after should not be stripped from non google emails",
)

def test_format_email_address_invalid_inputs(self):
with self.assertRaises(ValueError):
self.formatter.format_email_address(None)
Expand Down