chore: create workflow to check showcase commit#13305
Open
sofisl wants to merge 12 commits into
Open
Conversation
A Go script and workflow are added to check that the showcase commit in librarian.yaml is in sync with the gapic-showcase.version property in java-showcase/gapic-showcase/pom.xml. Fixes googleapis/librarian#6200
A Go script and workflow are added to check that the showcase commit in librarian.yaml is in sync with the gapic-showcase.version property in java-showcase/gapic-showcase/pom.xml. Fixes googleapis/librarian#6200
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new Go script, .github/scripts/verify_showcase_version.go, to verify that the showcase version and commit are in sync by querying the remote repository using git ls-remote. A review comment identifies an issue where annotated tags in Git produce multiple lines in the git ls-remote output, which can cause the script to incorrectly parse the tag object's hash instead of the actual commit hash. A code suggestion is provided to parse the output line-by-line to correctly identify the dereferenced commit.
Contributor
Author
|
The logic is pretty complicated so I think maybe putting it all in a go file would be better, but I'm taking from this that maybe you'd prefer some more bash scripting. |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
zhumin8
reviewed
May 29, 2026
zhumin8
reviewed
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A workflow to make sure the showcase commit is the same as what is in librarian. If the workflow fails, or there is a mismatch, an issue will be created.
Fixes googleapis/librarian#6200