Allow 0xDEAD exitcode on windows guard page tests#1515
Merged
Conversation
ludfjig
requested review from
andreiltd,
danbugs,
dblnz,
devigned,
jprendes,
jsturtevant,
simongdavies,
squillace and
syntactically
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the Windows guard page subprocess test more tolerant of an intermittent CI-specific termination code (0xDEAD / 57005), treating it as an acceptable alternative to STATUS_ACCESS_VIOLATION when verifying that guard pages still trap as expected.
Changes:
- On Windows, accept exit code
0xDEADin addition toSTATUS_ACCESS_VIOLATIONwhen determining whether the guard-page subprocess died due to the expected fault. - Add inline commentary linking the behavior to issue #1507 for traceability.
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
force-pushed
the
fix_guardpage_dead_exitcode
branch
from
77cb15f to
413dd62
Compare
jsturtevant
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1507