TPT-3501: Support NodeBalancer lke_cluster field#689
Open
jbilskiAkam wants to merge 3 commits into
Conversation
jbilskiAkam
requested review from
Copilot and
yec-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Adds client support and test coverage for the new read-only NodeBalancer field lke_cluster.
Changes:
- Added
lke_clusteras aProperty(json_object=...)onNodeBalancer. - Introduced
LKEClusteras aJSONObjectdataclass for decoding the nested object. - Updated fixtures and unit tests to validate both populated and
nulllke_clusterresponses.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
linode_api4/objects/nodebalancer.py |
Adds lke_cluster property mapping to decode the nested cluster reference. |
linode_api4/common.py |
Introduces LKECluster JSONObject schema used by NodeBalancer decoding. |
test/fixtures/nodebalancers.json |
Adds lke_cluster (object and null) to list fixture payload. |
test/fixtures/nodebalancers_123456.json |
Adds lke_cluster object to single NodeBalancer fixture payload. |
test/unit/objects/nodebalancers_test.py |
Extends list/get tests to assert lke_cluster decoding; fixes a docstring typo. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yec-akamai
requested review from
a team and
jriddle-linode
and removed request for
a team
yec-akamai
requested review from
a team and
psnoch-akamai
and removed request for
a team
jbilskiAkam
force-pushed
the
feature/TPT-3501-python-sdk-support-nodebalancer-lke_cluster-and-type-fields
branch
from
ea944b1 to
2466c3a
Compare
jbilskiAkam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds support for the new read-only field
lke_clusterin the NodeBalancer struct.✔️ How to Test
To run relevant unit tests use: