Skip to content

RPC V2 Tests#151

Open
stephen-derosa wants to merge 1 commit into
livekit:mainfrom
stephen-derosa:sderosa/BOT-379-RPC-V2
Open

RPC V2 Tests#151
stephen-derosa wants to merge 1 commit into
livekit:mainfrom
stephen-derosa:sderosa/BOT-379-RPC-V2

Conversation

@stephen-derosa
Copy link
Copy Markdown
Collaborator

@stephen-derosa stephen-derosa commented Jun 2, 2026

Overview

RPC V2 supports up to 15KB rpc calls. This integrates the happy path of the client-sdk-js RPC Specs

These tests explicitly test payloads larger than 15kb

@stephen-derosa stephen-derosa self-assigned this Jun 2, 2026
Copilot AI review requested due to automatic review settings June 2, 2026 04:23
@stephen-derosa stephen-derosa marked this pull request as draft June 2, 2026 04:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the RPC integration test suite to exercise “RPC V2” behavior, especially around payload sizes that exceed the legacy RPC v1 ~15KB packet limit, and adds additional metadata assertions for basic round-trips.

Changes:

  • Introduces explicit constants for the RPC v1 payload limit and a larger payload size, plus a shared checksumPayload() helper.
  • Expands integration coverage with new large request/response (and combined) round-trip tests.
  • Adjusts the concurrent RPC calls test to use larger payloads and simplified handler responses.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/tests/integration/test_rpc.cpp
Comment thread src/tests/integration/test_rpc.cpp
@stephen-derosa stephen-derosa changed the title RPC V2 RPC V2 Tests Jun 2, 2026
@stephen-derosa stephen-derosa marked this pull request as ready for review June 2, 2026 04:28
@stephen-derosa stephen-derosa requested a review from Copilot June 2, 2026 04:30
@stephen-derosa stephen-derosa force-pushed the sderosa/BOT-379-RPC-V2 branch from 9105244 to 472f73a Compare June 2, 2026 04:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Comment thread src/tests/integration/test_rpc.cpp
Comment thread src/tests/integration/test_rpc.cpp
Comment thread src/tests/integration/test_rpc.cpp
Comment thread src/tests/integration/test_rpc.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants