[MAPBOX] fix: missing Maps/Stadia api key app crashes#3552
Open
quimodotcom wants to merge 3 commits into
Open
Conversation
quimodotcom
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #3549.
Right now the code for the map part just assumes there is always going to be a valid api key. Without one it crashes some apps; Revolut is the one that this happens to for me as of Q1 2026 updates.
This pull request adds a fallback called DummyGoogleMapImpl and basically shows nothing instead.
The class acts like the real google map one but returns a blank frame layout. MapFragment and MapView were updated to check for keys and use the dummy when nothing is found. CreatorImpl also got changed in its get renderer type method so it returns zero without a key.
It seems like the goal is to make builds more stable when no map key was added. Some parts still feel a bit unclear about how it all connects though.