Add Cast framework dynamite module descriptor#3554
Open
Jorel97 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a local Dynamite
ModuleDescriptorforcom.google.android.gms.cast.framework.dynamitein the Cast framework core module.The Cast framework loader already has a local
CastDynamiteModuleImpl, andDynamiteLoaderImplhas a temporary version fallback for this same module id. This descriptor makes the module discoverable through the standard local descriptor path used byDynamiteModule.getLocalVersion(...).Scope
This is intentionally small and does not claim to complete Google Cast v2 support by itself. It is a supporting fix for the Cast framework dynamite loading path related to #580.
It also does not overlap with the existing route-controller work in #3505 or the broader session/controller changes in #3377.
Validation
From a short Windows path mounted with
subst G:to avoid Android AIDL path-length failures:Result: build successful.
Refs #580