Skip to content

chore: add rolldown customization#829

Merged
avivkeller merged 2 commits into
mainfrom
more-custom-tw
Jun 4, 2026
Merged

chore: add rolldown customization#829
avivkeller merged 2 commits into
mainfrom
more-custom-tw

Conversation

@avivkeller
Copy link
Copy Markdown
Member

No description provided.

@avivkeller avivkeller requested a review from a team as a code owner June 4, 2026 15:56
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Jun 4, 2026 8:38pm

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented Jun 4, 2026

PR Summary

Medium Risk
Changes core bundling merge behavior for all web builds; misconfigured rolldown overrides (e.g. external, platform) could break client or server output.

Overview
Adds a web.rolldown config hook so doc-kit consumers can extend the client and server Rolldown builds (extra plugins, defines, aliases, and other BuildOptions) without forking the generator. bundle.mjs spreads user options into build() with documented merge rules: user plugins slot between the virtual module plugin and the CSS loader; transform.define and resolve.alias merge with generator defaults while SERVER/CLIENT, Preact aliases, and imports still win; other fields can override defaults such as external or platform.

The web generator README documents the option and notes that function-valued settings are safe today because the web generator runs on the main thread. css.mjs honors lightningcss.resolver.read when reading CSS files. Package version is bumped to 1.3.9.

Reviewed by Cursor Bugbot for commit 3bf16bc. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-advanced-security

This comment was marked as outdated.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 63c2ce1. Configure here.

Comment thread src/generators/web/utils/bundle.mjs
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

❌ Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.34%. Comparing base (e2063d4) to head (3bf16bc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/generators/web/utils/bundle.mjs 89.65% 3 Missing ⚠️
src/generators/web/utils/css.mjs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #829   +/-   ##
=======================================
  Coverage   84.33%   84.34%           
=======================================
  Files         172      172           
  Lines       15421    15447   +26     
  Branches     1362     1367    +5     
=======================================
+ Hits        13006    13028   +22     
- Misses       2406     2409    +3     
- Partials        9       10    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller avivkeller merged commit 6b1b38f into main Jun 4, 2026
22 of 23 checks passed
@avivkeller avivkeller deleted the more-custom-tw branch June 4, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants