Skip to content

fix: collect all PR-URL entries in getAltPrUrl()#1090

Open
watilde wants to merge 1 commit into
nodejs:mainfrom
watilde:fix/PR
Open

fix: collect all PR-URL entries in getAltPrUrl()#1090
watilde wants to merge 1 commit into
nodejs:mainfrom
watilde:fix/PR

Conversation

@watilde
Copy link
Copy Markdown
Member

@watilde watilde commented Jun 7, 2026

getAltPrUrl() was only ever returning the first PR-URL entry in a commit message body. The root cause was PR_RE missing the global flag (g), so text.match(PR_RE) returned a single match-result array (full match + capture group) instead of an array of all matching lines.

This follows the existing pattern in the file where FIXES_RE/FIX_RE and REFS_RE/REF_RE are paired as global/non-global variants. Added PRS_RE as the global counterpart and updated getAltPrUrl() to use it.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.13%. Comparing base (4ea22b8) to head (6a85c35).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
+ Coverage   64.93%   65.13%   +0.20%     
==========================================
  Files          45       45              
  Lines        6938     6939       +1     
==========================================
+ Hits         4505     4520      +15     
+ Misses       2433     2419      -14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant