Harden reselect against empty/undefined calcdata entries#7820
Open
TheSisb wants to merge 1 commit into
Open
Conversation
reselect runs unconditionally at the end of every redraw sequence (newPlot / react / relayout / resize). Its helper epmtySplomSelectionBatch iterates gd.calcdata and dereferences cd[i][0] with no guard, so a transient empty or undefined calcdata entry throws "Cannot read properties of undefined (reading '0')" and kills the chart even when no selection exists. The sibling supplyDefaultsUpdateCalc already guards the same access with (oldCalcdata[i] || [])[0]; make epmtySplomSelectionBatch and determineSearchTraces equally defensive by skipping empty/undefined entries. Add a jasmine spec covering both cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip empty/undefined calcdata entries in
epmtySplomSelectionBatchanddetermineSearchTracesinstead of dereferencing them.What happens
reselectruns unconditionally at the end of every redraw sequence (newPlot/react/relayout/ resize). Its helperepmtySplomSelectionBatchiteratesgd.calcdataand dereferencescd[i][0]with no guard:When gd.calcdata contains an empty ([]) or undefined entry, this throws
and the redraw promise rejects: