Skip to content

gh-149924: add tests to improve coverage for test_complex_special #150938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aniketsy wants to merge 5 commits into
base: main
Choose a base branch
from
+16 −0
Open

gh-149924: add tests to improve coverage for test_complex_special #150938

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d24e6ea
add tests to improve coverage for test_complex_special
Aniketsy Jun 5, 2026
deb883e
add tests to improve coverage for test_complex_special
Aniketsy Jun 5, 2026
c1d0a00
Update Lib/test/test_cmath.py
Aniketsy Jun 5, 2026
53f0083
use cmath instead of math and remove itertools import
Aniketsy Jun 5, 2026
12f3f9c
test improvemnet
Aniketsy Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Lib/test/test_cmath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,22 @@ def test_complex_special(self):
self.assertIsNotClose(-INF, INF)
self.assertIsNotClose(0, INF)
self.assertIsNotClose(0, INF*1j)
special = [INF, -INF, NAN, 0.0, -0.0, 1.0]
special_complex = [complex(x, y) for x in special for y in special]

nan_complex = [c for c in special_complex if cmath.isnan(c)]
for z in nan_complex:
for w in special_complex:
self.assertIsNotClose(z, w)

inf_complex = [c for c in special_complex
if cmath.isinf(c) and not cmath.isnan(c)]
for z in inf_complex:
for w in inf_complex:
if z != w:
self.assertIsNotClose(z, w)
else:
self.assertIsClose(z, z)
Comment on lines +593 to +608
Copy link
Copy Markdown
Member

@skirpichev skirpichev Jun 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, the test_cmath.py file has global variables for complex nans and infinities. You can reuse them here:

Suggested change
special = [INF, -INF, NAN, 0.0, -0.0, 1.0]
special_complex = [complex(x, y) for x in special for y in special]
nan_complex = [c for c in special_complex if cmath.isnan(c)]
for z in nan_complex:
for w in special_complex:
self.assertIsNotClose(z, w)
inf_complex = [c for c in special_complex
if cmath.isinf(c) and not cmath.isnan(c)]
for z in inf_complex:
for w in inf_complex:
if z != w:
self.assertIsNotClose(z, w)
else:
self.assertIsClose(z, z)
for z in complex_nans:
for w in complex_infinities + complex_nans:
self.assertIsNotClose(z, w)
for z in complex_infinities:
for w in complex_infinities:
if z != w:
self.assertIsNotClose(z, w)
else:
self.assertIsClose(z, z)



if __name__ == "__main__":
Expand Down
Loading