Skip to content

gh-150942: Speed up re.findall and re.sub/subn result building #150943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eendebakpt wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −8
Open

gh-150942: Speed up re.findall and re.sub/subn result building #150943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
191730a
gh-XXXXX: Speed up re.findall and re.sub/subn result building
eendebakpt May 31, 2026
bf25fc5
gh-150942: Set issue number on the re speedup news entry
eendebakpt Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2026-05-31-12-00-00.gh-issue-150942.Re7Ref.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Speed up :func:`re.findall`, :func:`re.sub` and :func:`re.subn` by appending
result items to the output list without an extra reference-count round-trip
(using the internal reference-stealing list append helper).
13 changes: 5 additions & 8 deletions Modules/_sre/sre.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ static const char copyright[] =
#include "pycore_critical_section.h" // Py_BEGIN_CRITICAL_SECTION
#include "pycore_dict.h" // _PyDict_Next()
#include "pycore_long.h" // _PyLong_GetZero()
#include "pycore_list.h" // _PyList_AppendTakeRef()
#include "pycore_moduleobject.h" // _PyModule_GetState()
#include "pycore_tuple.h" // _PyTuple_FromPairSteal
#include "pycore_unicodeobject.h" // _PyUnicode_Copy
Expand Down Expand Up @@ -980,8 +981,7 @@ _sre_SRE_Pattern_findall_impl(PatternObject *self, PyObject *string,
break;
}

status = PyList_Append(list, item);
Py_DECREF(item);
status = _PyList_AppendTakeRef((PyListObject *)list, item);
if (status < 0)
goto error;

Expand Down Expand Up @@ -1327,8 +1327,7 @@ pattern_subx(_sremodulestate* module_state,
string, i, b);
if (!item)
goto error;
status = PyList_Append(list, item);
Py_DECREF(item);
status = _PyList_AppendTakeRef((PyListObject *)list, item);
if (status < 0)
goto error;

Expand Down Expand Up @@ -1357,8 +1356,7 @@ pattern_subx(_sremodulestate* module_state,

/* add to list */
if (item != Py_None) {
status = PyList_Append(list, item);
Py_DECREF(item);
status = _PyList_AppendTakeRef((PyListObject *)list, item);
if (status < 0)
goto error;
}
Expand All @@ -1375,8 +1373,7 @@ pattern_subx(_sremodulestate* module_state,
string, i, state.endpos);
if (!item)
goto error;
status = PyList_Append(list, item);
Py_DECREF(item);
status = _PyList_AppendTakeRef((PyListObject *)list, item);
if (status < 0)
goto error;
}
Expand Down
Loading