gh-150942: Speed up json.loads array and object decoding#150945
Open
eendebakpt wants to merge 1 commit into
Open
gh-150942: Speed up json.loads array and object decoding#150945eendebakpt wants to merge 1 commit into
eendebakpt wants to merge 1 commit into
Conversation
Append parsed values to the result list with _PyList_AppendTakeRef and insert key/value pairs with _PyDict_SetItem_Take2, which take ownership of the references instead of incref-ing on insert and then decref-ing the local. This removes a reference-count round-trip per element (and, on the free-threaded build, a per-append lock). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmarks on FT build:
array_stringsarray_intsconfigbm_json_loadsThe relative performance gain is larger with #150639 included (geomean 1.12x)
Benchmark script