gh-150942: Speed up csv.reader row building#150995
Open
omkar-334 wants to merge 4 commits into
Open
Conversation
eendebakpt
reviewed
Jun 6, 2026
| } | ||
| if (PyList_Append(self->fields, field) < 0) { | ||
| Py_DECREF(field); | ||
| if (_PyList_AppendTakeRef((PyListObject *)self->fields, field) < 0) { |
Contributor
There was a problem hiding this comment.
The list used here is self->fields. Can we guarantee that it is not mutated by concurrent threads?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
_PyList_AppendTakeRefwhile collecting fields incsv.readerinstead ofPyList_Appendfollowed byPy_DECREF, removing an incref/decref pair perparsed field.
Microbenchmarks
Release build, macOS
csv_reader_2m_fieldscsv_reader_400k_fields_8colcsv_reader_80k_fieldsBenchmark script