gh-151126: Add missing PyErr_NoMemory in _winapi module#151154
Merged
Conversation
zooba
approved these changes
Jun 9, 2026
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-151180 is a backport of this pull request to the 3.15 branch. |
|
GH-151181 is a backport of this pull request to the 3.14 branch. |
|
GH-151182 is a backport of this pull request to the 3.13 branch. |
sobolevn
added a commit
that referenced
this pull request
Jun 9, 2026
sobolevn
added a commit
that referenced
this pull request
Jun 9, 2026
sobolevn
added a commit
that referenced
this pull request
Jun 9, 2026
clin1234
pushed a commit
to clin1234/cpython
that referenced
this pull request
Jun 9, 2026
Member
|
I am not sure this caused crash. At least not in the first case. But adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This place misses it:
cpython/Modules/_winapi.c
Lines 1196 to 1198 in 9fdbade
It is used as:
It would be rather strange to swallow
MemoryErrorhere.Before that we allow
KeyErrorto pass silently and return early if this code path should not be taken:All other error paths in the same function set exceptions, except this
if:cpython/Modules/_winapi.c
Lines 1278 to 1282 in 9fdbade
Later this
NULLis returned from_winapi.CreateProcesswithout an exception set.PyErr_NoMemory()call after failing memory allocation #151126