Skip to content

gh-109940: Respect VIRTUAL_ENV_DISABLE_PROMPT in activate.bat#151215

Merged
vsajip merged 1 commit into
python:mainfrom
harjothkhara:gh-109940-venv-disable-prompt
Jun 10, 2026
Merged

gh-109940: Respect VIRTUAL_ENV_DISABLE_PROMPT in activate.bat#151215
vsajip merged 1 commit into
python:mainfrom
harjothkhara:gh-109940-venv-disable-prompt

Conversation

@harjothkhara

@harjothkhara harjothkhara commented Jun 10, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@python-cla-bot

python-cla-bot Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

bedevere-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app Bot mentioned this pull request Jun 10, 2026
Closed
@harjothkhara harjothkhara force-pushed the gh-109940-venv-disable-prompt branch 2 times, most recently from fca4663 to 45230fe Compare June 10, 2026 02:15
@harjothkhara harjothkhara force-pushed the gh-109940-venv-disable-prompt branch from 45230fe to 8f35394 Compare June 10, 2026 02:31
@harjothkhara harjothkhara marked this pull request as ready for review June 10, 2026 03:19
@vsajip vsajip merged commit 7a014f4 into python:main Jun 10, 2026
57 checks passed
@vsajip vsajip added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 10, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

Thanks @harjothkhara for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

Thanks @harjothkhara for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

Thanks @harjothkhara for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

Sorry, @harjothkhara and @vsajip, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7a014f44c393fda6d1c4bd135608ebcfc21d626c 3.13

@miss-islington-app

miss-islington-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

Sorry, @harjothkhara and @vsajip, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7a014f44c393fda6d1c4bd135608ebcfc21d626c 3.14

@bedevere-app

bedevere-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

GH-151225 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 10, 2026
@harjothkhara harjothkhara mentioned this pull request Jun 10, 2026
Merged
@bedevere-app

bedevere-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

GH-151263 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 10, 2026
@harjothkhara harjothkhara mentioned this pull request Jun 10, 2026
Merged
@bedevere-app

bedevere-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

GH-151264 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 10, 2026
vsajip pushed a commit that referenced this pull request Jun 10, 2026
@miss-islington @harjothkhara
[3.15] gh-109940: Respect VIRTUAL_ENV_DISABLE_PROMPT in activate.bat (G…
5c83037 
…H-151215) (GH-151225)

Co-authored-by: Harjoth Khara <harjoth.khara@gmail.com>
vsajip pushed a commit that referenced this pull request Jun 10, 2026
@harjothkhara
[3.13] gh-109940: Respect VIRTUAL_ENV_DISABLE_PROMPT in activate.bat (G…
4866da0 
…H-151215) (GH-151263)
vsajip pushed a commit that referenced this pull request Jun 10, 2026
@harjothkhara
[3.14] gh-109940: Respect VIRTUAL_ENV_DISABLE_PROMPT in activate.bat (G…
b0a90a9 
…H-151215) (GH-151264)

(cherry picked from commit 7a014f4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip vsajip approved these changes

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees

@vsajip vsajip

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harjothkhara @vsajip