gh-150988: Fix OSError reference leak in oserror_init()#151219
Closed
bhuvi27 wants to merge 1 commit into
Closed
Conversation
Use Py_XSETREF when assigning errno, strerror, filename, filename2, and winerror so pre-existing references from subclass __init__ are released.
bhuvi27
force-pushed
the
gh-150988-fix-oserror-refleak
branch
from
1ff7ad9 to
7cbe7a5
Compare
Author
|
Closing in favour of #150990 — same fix, already reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #150988
Assigning OSError fields in a subclass before super().init() stored
references in the C struct that oserror_init() later overwrote without
decref'ing, leaking one reference per field per exception.
Use Py_XSETREF when updating errno, strerror, filename, filename2, and
winerror. Add a refcount regression test in test_exceptions.py.
OSErrorwhen setting attributes beforesuper().__init__#150988