[codex] Stream IMAP fetch literals#111
Open
mpscholten wants to merge 2 commits into
Open
Conversation
fe7f0c0 to
ceb90ce
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
bb73a34 to
6a32ebb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the high memory usage reported in #39 when fetching full IMAP message bodies.
This changes the IMAP fetch path so literal response bodies are read as
ByteStrings directly from the stream instead of being parsed through the existing packrat/String parser and then packed back intoByteString.Root Cause
fetchreturned aByteString, but internally it went throughfetchByString, causing large IMAP literals to be represented as:StringByteStringThat made full-message fetches allocate far more memory than the message size.
Changes
fetchByByteStringandfetchByByteStringR.fetch,fetchPeek,fetchHeader,fetchR, and related APIs through the ByteString-native path.fetchByStringandfetchByStringRas compatibility wrappers and documented the ByteString variants as preferred for large or non-textual values.FETCHresponses directly fromBSStreamand read{n}literals withbsGet n.NILas raw response bytes instead of converting them to empty values.fetchPeek,fetchSize,fetchFlags, header-field sections, range UID mapping,fetchByStringscalar/literal/NIL values, and STORE responses.Validation
nix shell github:NixOS/nixpkgs/nixos-25.05#ghc github:NixOS/nixpkgs/nixos-25.05#cabal-install -c cabal test imap-parsers --test-options='--hide-successes'master.A compiled synthetic benchmark showed much lower peak RSS after streaming: