Keep internal quarto.* template variables out of the render message#14569
Merged
Conversation
The quarto.* Pandoc template-variable namespace (#14530) carries the full localized language table, surfaced through the defaults-file variables: section so it stays out of yaml_metadata_block writers. That section is still echoed verbatim in the "pandoc ..." defaults message printed during render, so every render now dumps the entire language table to the console. Strip the namespace in pandocDefaultsMessage, alongside the existing print-only cleaning for patched templates and extension writers. This is display-only: writeDefaultsFile keeps quarto.* intact, so template resolution is unaffected. User-set variables still print.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This smoke test asserted a negative: that verapdf would fail UA-2 validation for an unlabeled captioned figure, because tagpdf placed <Caption> as a sibling of <Figure> rather than nesting it. Newer tagpdf/luamml in current TeX Live make verapdf pass UA-2 for the same document, so the expected failure warning never prints and the test breaks on CI. Negate the assertion so the test verifies validation now passes. Whether the structure tree is genuinely conforming or verapdf simply stopped flagging it is tracked in #14570.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rendering any document, the full localized
quarto.*template-variable namespace introduced in #14530 is dumped to the console as part of thepandoc ...defaults message — dozens of language-table lines on every render.The namespace is surfaced through the defaults-file
variables:section (so it stays out ofyaml_metadata_blockwriters), and that section is echoed verbatim in the printed defaults message.pandocDefaultsMessageinsrc/command/render/defaults.tsnow strips thequarto.*namespace, alongside the existing print-only cleaning for patched templates and extension writers. This is display-only:writeDefaultsFilekeeps the namespace intact, so template resolution is unaffected, and user-setvariables:still print.Related to #14530