Sync fork with chromium/7827#261
Draft
huntie wants to merge 5813 commits into
Draft
Conversation
This change documents the initial context and tool data provided to the Performance Agent. It was prompted by debugging a case where a tool wasn't being called, which required tracing what context the agent already possessed. This reference should simplify future debugging. The file is structured to accommodate other agents in the future. Bug: 500674956 Change-Id: I38b52adbeb62988955bebb9bb490fb4dc55b514f Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7748000 Commit-Queue: Alina Varkki <alinavarkki@chromium.org> Auto-Submit: Alina Varkki <alinavarkki@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
This would sometimes cause value field to get sliced as "olumn" instead of "column" Bug: 446127731 Change-Id: I87ffd0933f2a1b57330f6341c2a78ae293ad4e25 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7761329 Commit-Queue: Samiya Caur <samiyac@chromium.org> Auto-Submit: Samiya Caur <samiyac@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/caace1c..37d1660 Roll created at https://cr-buildbucket.appspot.com/build/8684546568115383121 Bug: none Change-Id: Ibb7cded2e2c072fa7b6dbb163bb6b016db3affff Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7759361 Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
We need this for the work in the MCP, as we have to create a separate entry point that get's bundled via Rollup. Bug: 454624251 Change-Id: I4ff8af7d163888f361572dd45d909eeafbb66d68 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7761664 Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Small stylistic changes that don't affect runtime. Bug: none Change-Id: I2e846148be13bd45bed8ae85ae53dd348da4c2d6 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7759595 Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org> Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org> Reviewed-by: Samiya Caur <samiyac@chromium.org>
Bug: 498224643 Change-Id: I5b5607eb58f230c1d27ed96b7a094be77384a0b8 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7761328 Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
This adds some properties to control whether to show the target selector and command name, as well as a setter for the metadata. Also adds an UNKNOWN parameter type which takes raw json. Bug: 494516094 Change-Id: I8bef6342332512ed56f5fd2b0870fdd1fd862130 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7761663 Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/37d1660..8fbdc08 Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/11cc2bd..7c8d573 Roll created at https://cr-buildbucket.appspot.com/build/8684489952310063361 Bug: none Change-Id: I9423fd0984d85dd38a499093a6b9cf055b49c78a Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7763033 Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
This CL fixes a case where: 1. We ship AIv2 2. A user enables AI Assistance for the first time 3. They go to AI Assistance, and see the opt-in dialog. (3) is not correct; because the user opted in under V2, they do not need to see the dialog. This CL fixes this by setting the dialog to "seen" in the event that a user with V2 enables it. Fixed: 502511336 Change-Id: I9753fa60c1c749f5e10d78ff0c36b6c46053028e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7760115 Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Fixed: 502765435 Change-Id: I8ad652988857b2bc690595747e7e2c471f608d83 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7759604 Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Auto-Submit: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Necessary if we want to upgrade to TS7 (tsgo). R=pfaffe@chromium.org Bug: None Change-Id: I83f5f39a454d176896a1cef62e4e3ca229bb13e7 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7759596 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
This CL adds the necessary types to parse `Error.stack`-like strings into a fully structured format. The UI can then re-serialize it out in whatever form it so chooses. We'll store the parse result on trie nodes themselves. If a frame with the same scriptId/column/line is already present, we'll augment the trie node with the parsed info if none exists yet. When translating, we expose the additional info using a new frame and fragment type that mirrors what we did for `DebuggableFrame`. We don't just forward the info either, we'll translate the eval origins so they are actually source mapped as well. R=pfaffe@chromium.org Bug: 485142682 Change-Id: I261c21e711a6aa4d179984ef08305c653e1a48a9 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7754100 Reviewed-by: Philip Pfaffe <pfaffe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org>
This function is similar to the previously existent getMainThreadTrackSummary that returns a summary for provided time bounds. The addition of getMainThreadTrackSummaryByLabel is motivated by getMainThreadTrackSummary not being used by the agent often. When we give the agent an ability to just provide the time bounds label, it seems to use it much more often. This change is also editing the preamble to encourage the agent to get main thread data more. Bug: 500674956 Change-Id: I864ffe63176ad5a82d3797e9d65f7e3b39d55ae2 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7749146 Auto-Submit: Alina Varkki <alinavarkki@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
As of TS 6 this is a requirement to explicitly list them. Bug: None Change-Id: I6522d5fd633b2c04fbe3e98b2b3a41628bc5834b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7758972 Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org>
This reverts commit 791a3ee. Reason for revert: https://crrev.com/c/7762248 Original change's description: > [cxx_debugging] Fix deprecated tsconfig options > > Necessary if we want to upgrade to TS7 (tsgo). > > R=pfaffe@chromium.org > > Bug: None > Change-Id: I83f5f39a454d176896a1cef62e4e3ca229bb13e7 > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7759596 > Auto-Submit: Simon Zünd <szuend@chromium.org> > Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> > Reviewed-by: Philip Pfaffe <pfaffe@chromium.org> Bug: None No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I0727a3ccaecad758e00c76366138a36e73b3a02b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7762249 Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
WCAG 3 has not decided on a contrast algorithm yet, so by default we want to keep the existing WCAG 2 algorithm, but allow users to switch to APCA if they want to. The CL includes a migration, such that users who have the APCA experiment enabled, will have the setting enabled automatically. Fixed: 476074456 Change-Id: Ie231d861ee690012768f16da8353b448ab4e478c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7705112 Auto-Submit: Wolfgang Beyer <wolfi@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
This roll requires a manual review. See http://go/reviewed-rolls for guidance. Rolling CfT pin together with browser-protocol files: https://chromium.googlesource.com/chromium/src/+log/a287ca9049cc3727d680078c1d9275b32f721c2d..aa779a3f59f2eda5d9befe0632bc75c1a05fe8dd In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS. Roll created at https://cr-buildbucket.appspot.com/build/8684489952310063361 R=chrome-devtools-waterfall-gardener-emea-oncall@google.com Bug: none Change-Id: I8dab1ca36ef8003fe7c92f7dd44bd100ba28f8e4 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7759826 Reviewed-by: Philip Pfaffe <pfaffe@chromium.org> Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org> Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org> Owners-Override: Kateryna Prokopenko <kprokopenko@chromium.org>
This reverts commit fcfd559. Reason for revert: Breaks the no_bundle builds: https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_check_no_bundle/1682/overview Original change's description: > [deps] Update typescript to 6.0.2 > > Requires some minor changes to make the new version happy, but looks > like we are good to go for tsgo :) > > R=alexrudenko@chromium.org, nvitkov@chromium.org > > Update-Node-Dependencies: New tsc version > Bug: None > Change-Id: Ice9f65be7c5d644713c9dc4adc3113df2d3e3914 > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7747364 > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> > Auto-Submit: Simon Zünd <szuend@chromium.org> > Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Bug: None No-Presubmit: true No-Tree-Checks: true Change-Id: Ie6a1470e7f519d3de11ffe6039c23d8513546f0d Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7762248 Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Auto-Submit: Philip Pfaffe <pfaffe@chromium.org> Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
The schema format isn't spec'ed but based on explainers and examples it's JSON schema. V7 is the latest we have in the repo, it should work for now. Bug: 494516094 Change-Id: I0348174f353476582ac6271d9fe3aa82391fbbe2 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7758778 Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Even though the status is Completed, a tool call could still have failed semantically and communicate that in plain text to the agent. Bug: 494516094 Change-Id: I022a390e6d2adef06537f2b546c8099152027e0a Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7758779 Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Auto-Submit: Philip Pfaffe <pfaffe@chromium.org> Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
This change introduces a new wrapper around Lit's `render` function that allows managing properties of the container element, such as its attributes, classes, and event listeners. The new `render` function in `front_end/ui/lit/render.ts` accepts `attributes`, `classes`, and `listeners` to be applied to the container as additional options. The function keeps track of previously applied properties and correctly adds, removes, or updates them on subsequent render calls, effectively "adopting" the container element. This new capability is used to refactor several UI components that do not use a shadow DOM. Previously, these components passed properties like CSS classes and `jslog` attributes to the `UI.Widget` constructor. This change moves this logic into the component's render call, co-locating it with the Lit template that defines the component's internal DOM. This makes the rendering logic more self-contained and easier to reason about. Bug: 407751340 Change-Id: I5427bcc7a28f596227af8aeff799825635069617 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7716198 Reviewed-by: Philip Pfaffe <pfaffe@chromium.org> Commit-Queue: Danil Somsikov <dsv@chromium.org> Auto-Submit: Danil Somsikov <dsv@chromium.org>
Bug: 502891600 Change-Id: Ie24f3ccd2543c96fcdcbf9c90f23568e74958d16 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7758780 Auto-Submit: Kateryna Prokopenko <kprokopenko@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Bug: 502459959 Change-Id: Iafd3475641146fa59be65bd6052dd1c59b52026f Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7761793 Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Samiya Caur <samiyac@chromium.org> Auto-Submit: Samiya Caur <samiyac@chromium.org>
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/8fbdc08..9fd8acf Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b9d2b54..0ea4801 Roll created at https://cr-buildbucket.appspot.com/build/8684399354604051553 Bug: none Change-Id: Ibc6afd812cea785d37295d7cf8e3b7e014e54b40 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7766090 Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
I think this got changed by accident during the Greenlines, as the styles were not updated. Bug: 477911897 Change-Id: I4cd5ae1c9ebc531fe09f5c9341defb622f3a2256 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7761587 Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Bug: 502891604 Change-Id: I04637039ec69f534de56c49e3e826fd3276fd421 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7761678 Auto-Submit: Kateryna Prokopenko <kprokopenko@chromium.org> Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
When execution context's origin is `file://` - the `url.domain()` is an empty string and the item's subtitle becomes falsy. Since we predicated rendering of an item on presence of both title and subtitle - the items were not rendered while still taking space in the dropdown. Bug: 502830845 Change-Id: I17bfb26edafbc7471f782c953205fe1a49349943 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7761316 Commit-Queue: Samiya Caur <samiyac@chromium.org> Reviewed-by: Danil Somsikov <dsv@chromium.org> Reviewed-by: Samiya Caur <samiyac@chromium.org>
This CL re-implements Error.stack parsing. Compared to the existing parser, we produce a fully structured frame instead of a prefix, link info and suffix. The advantage is twofold: * We disentangle the Error.stack format a bit more from the UI. * We can source map the "eval origin" now as well. Follow-up changes will wire-up the parsing to the trie and the StackTraceModel. R=pfaffe@chromium.org Bug: 485142682 Change-Id: Iff98b82a27ae3ddd1256d5c8e5a50aecae350b2a Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7754102 Reviewed-by: Philip Pfaffe <pfaffe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org>
Fixed: 498942434 Change-Id: Ieea5870da1fa211901df4ecd40943a0bd1344fa9 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7761792 Commit-Queue: Alina Varkki <alinavarkki@chromium.org> Reviewed-by: Alina Varkki <alinavarkki@chromium.org> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
R=kimanh@chromium.org Bug: 503111303,502804868 Change-Id: Ib472dfb87341cac90f4cbec9dc97aa6cc5ceb28b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7767789 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
The timestamps have been being rendered as 'Undefined' for a while now. Apparently there was a drive-by change to this string that just broke things and there wasn't a test to catch it. Bug: none Change-Id: I725c06b3ebc1d1fd85d03cd24071b419c431861f Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7804752 Auto-Submit: Ted (Chromium) Meyer <tmathmeyer@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/b41aacc..084b7f0 Rolling buildtools/linux64: git_revision:d830369a8e7db2383ab7bb1c2c142ee2766cfea2..git_revision:1740f5c25bcac5a650ee3d1c1ec22bfa25fcd756 Rolling buildtools/mac: git_revision:d830369a8e7db2383ab7bb1c2c142ee2766cfea2..git_revision:1740f5c25bcac5a650ee3d1c1ec22bfa25fcd756 Rolling buildtools/win: git_revision:d830369a8e7db2383ab7bb1c2c142ee2766cfea2..git_revision:1740f5c25bcac5a650ee3d1c1ec22bfa25fcd756 Roll created at https://cr-buildbucket.appspot.com/build/8683006426552477073 Bug: none Change-Id: Ie5c7674dfbe86ca9200aa0090e84355927b522da Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7807136 Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/084b7f0..8a46ede Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/5a4d13c..5e7f45b Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1603cbd..ff41874 Roll created at https://cr-buildbucket.appspot.com/build/8682949799533745233 Bug: none Change-Id: I46c1ef79578be27c4e36d84cf388a988e7556ce1 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7810318 Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Add a toolbar toggle button that collapses or expands all console groups and stack traces at once, reducing clutter from console.trace(). Bug: 427657550 Change-Id: Ifc5bc617c244338f69b818343973baf4c0bf147d Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7575527 Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Samiya Caur <samiyac@chromium.org> Commit-Queue: Helmut Januschka <helmut@januschka.com>
Rolling third_party/clang-format/script: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format/+log/08cce2b..3a7d027 Roll created at https://cr-buildbucket.appspot.com/build/8682768609820460849 Bug: none Change-Id: I0ee5be6acf327048a2f8031f421400fa206a0cf7 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7812696 Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
This CL updates the generated text to be as per the valid properties - this will remove any inconsistencies between what is shown and what is accepted This CL also adds `}` as a stop sequence This CL also updates removePrompt impl to clear entire AI suggestion instead of just the value ghost text Bug: 502459959 Change-Id: I5eeda4c27f4936282e6ecfc7ed8feb26dd109255 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7806814 Auto-Submit: Samiya Caur <samiyac@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Samiya Caur <samiyac@chromium.org>
This roll requires a manual review. See http://go/reviewed-rolls for guidance. Rolling CfT pin together with browser-protocol files: https://chromium.googlesource.com/chromium/src/+log/1f344c5922432c73b3db8100c1f15163fdf8b530..e388465394450fcfccc5529cf634c8561999f3b8 In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS. Roll created at https://cr-buildbucket.appspot.com/build/8682768609820460849 R=chrome-devtools-waterfall-gardener-emea-oncall@google.com Bug: none Change-Id: I297580a84cc1272e60f36817615a85780c25716f Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7812697 Reviewed-by: Samiya Caur <samiyac@chromium.org> Commit-Queue: Samiya Caur <samiyac@chromium.org> Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
This CL also adds a11y announcements for display and acceptance of suggestions Bug: 507131448 Change-Id: I36b111e65d6889e7fd76aa73e1dbf79c4cada9c1 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7812256 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Samiya Caur <samiyac@chromium.org> Auto-Submit: Samiya Caur <samiyac@chromium.org> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Bug: 503622772 Change-Id: Ie259d4134e65f8abd7e27b909adfdf799af55f38 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7813575 Auto-Submit: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org> Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Bug: 505974404 Change-Id: I4c89b692f8edbd2b611b6f2e523242a1a258c6a8 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7806304 Auto-Submit: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org>
Bump so we have correct types for CDP Update-Node-Dependencies: fix for node_modules NO_IFTTT=Deps Bypass-Keep-Sorted: Deps Bug: none Change-Id: I19889e86f9848ea6ab06721874aec4407aa456db Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7812636 Reviewed-by: Liviu Rau <liviurau@chromium.org> Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Liviu Rau <liviurau@chromium.org>
This CL adds an ID field to messages which is generated with crypto.randomUUID(). Previously we relied on object equality but messages now get copied when we deduplicate widgets, and that exposed that the reliance on object equality is pretty brittle. This CL adds IDs and uses them to compare messages. Fixed: 508535515 Change-Id: I33cf5aed19916b3225bf96a021dcb7088692c5a3 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7806838 Reviewed-by: Alina Varkki <alinavarkki@chromium.org> Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Fixed: 508153374 Change-Id: I505119eb1a86458273b32f19be58e7a595b48023 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7812637 Auto-Submit: Samiya Caur <samiyac@chromium.org> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Samiya Caur <samiyac@chromium.org>
This roll requires a manual review. See http://go/reviewed-rolls for guidance. Rolling CfT pin together with browser-protocol files: https://chromium.googlesource.com/chromium/src/+log/{old_revision}..{new_revision} In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS. Roll created at https://cr-buildbucket.appspot.com/build/8682734632486095873 R=chrome-devtools-waterfall-gardener-emea-oncall@google.com Bug: none Change-Id: Ia387308653ae1478ebfce5952a0b326b07a519da Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7811946 Commit-Queue: Samiya Caur <samiyac@chromium.org> Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by: Samiya Caur <samiyac@chromium.org>
Rolling third_party/clang-format/script: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format/+log/3a7d027..6eddfb5 Roll created at https://cr-buildbucket.appspot.com/build/8682734632486095873 Bug: none Change-Id: Idf8c53a167ba8efc744c0bcb6bf0f6d659dbb8c9 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7813794 Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Flakiness was reproduced on changing the order in which tests are executed - pointing to some resource leak between test runs. This gets fixed on using describeWithMockConnection Bug: 509476756 Change-Id: Ied059eb65c8c0adc7855f22540f4ace8a1520adc Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7806140 Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Auto-Submit: Samiya Caur <samiyac@chromium.org> Commit-Queue: Samiya Caur <samiyac@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Bug: 40543651 Change-Id: I2b5fe2098c1e753300c9e0a8743404b5b5a5e63b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7805733 Commit-Queue: Lusa Zhan <lusazhan@chromium.org> Reviewed-by: Paul Irish <paulirish@chromium.org>
Original change's description: > Simplify AI completion/generation feature availability checks > > Instead of checking for all the different restrictions before instantiating providers - only check if the feature flag is on. > > As part of event listeners for AIDA_AVAILABILITY_CHANGED, check for other restrictions - locale, age, location etc. > > Fixed: 509339490 > Change-Id: Ie753154319ad366739f0a1c16bfb10b7831d6788 > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7817477 > Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> > Commit-Queue: Samiya Caur <samiyac@chromium.org> (cherry picked from commit 41e5041) Bug: 510779217,509339490 Change-Id: Ie753154319ad366739f0a1c16bfb10b7831d6788 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7828799 Auto-Submit: chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Original change's description: > Fix how disable_user_content_logging is being set > > Bug: 416159656 > Change-Id: Ic6c66e250f32fc688cd114b91e1634fc196cb4be > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7813579 > Auto-Submit: Samiya Caur <samiyac@chromium.org> > Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> (cherry picked from commit e4f130a) Bug: 510815005,416159656 Change-Id: Ic6c66e250f32fc688cd114b91e1634fc196cb4be Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7829478 Auto-Submit: chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
…opertyTreeElement Original change's description: > Improve how AI suggestion for value part is handled in StylePropertyTreeElement > > - Prevent ghost text display when suggestion matches existing value > - Ensure original validation classes are restored correctly after clearing suggestions > > Fixed: 509355620 > Change-Id: I13e167c34303019e1a7cf91a0227086410fae11c > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7826529 > Auto-Submit: Samiya Caur <samiyac@chromium.org> > Commit-Queue: Samiya Caur <samiyac@chromium.org> > Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> (cherry picked from commit 132796a) Bug: 510790623,509355620 Change-Id: I13e167c34303019e1a7cf91a0227086410fae11c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7832346 Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Original change's description: > Insights: fix broken re-rendering of Insights > > This CL makes a change to how we render Insights in the sidebar. We > found that if you have two traces, and the ordering of the Insights in > the sidebar changes, you could end up with a completely broken sidebar. > In the logs, this would appear as the code passing the LCP Breakdown > model into the Cache insight, for example. > > Tracking this down, I think it is down to how Lit deals with trying to > re-render efficiently. Now we are rendering a series of > devtools-widgets, rather than the component itself, it would not always > destroy and re-order the list. > > Looking at > https://lit.dev/docs/templates/lists/#when-to-use-map-or-repeat, it > states: > > > If the DOM nodes have state that isn't controlled by a template > > expression, use the repeat directive. > > The introduction of the repeat() directive here, even though we have > just one item in the array, provides a way for us to put an explicit key > to the node. In this case, the key is the model (each trace has unique > model references) and Lit supports using an object here. Doing this > means we relate the DOM to the exact model that backs it and avoids any > chance of Lit trying to reuse elements and causing a breakage. > > Bug: 498621626 > Change-Id: I1f23bba7fd3ad818632c0f6484085ebd318d1659 > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7817996 > Commit-Queue: Alina Varkki <alinavarkki@chromium.org> > Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> > Reviewed-by: Alina Varkki <alinavarkki@chromium.org> > Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> (cherry picked from commit 51757ea) Bug: 511161025,498621626 Change-Id: I1f23bba7fd3ad818632c0f6484085ebd318d1659 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7835295 Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Original change's description: > AI: use ContentData for network request image rendering > > In AI Assistance, network request image previews now use the ContentData > model instead of raw data URLs. This aligns with DevTools standards and > allows for efficient rendering using blob URLs for larger images. > > The DomTreeAiWidget now carries the ContentData object directly, which > is populated by the PerformanceAgent and consumed by ChatMessage. > > Added unit tests to verify the population and rendering of the image > content, and refactored related tests to follow project conventions. > > Fixed: 510287771 > Change-Id: I97295095fa9d7491ac195a12c0fec417a7cc377e > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7827672 > Commit-Queue: Alina Varkki <alinavarkki@chromium.org> > Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> > Reviewed-by: Alina Varkki <alinavarkki@chromium.org> > Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> (cherry picked from commit 8fc05f2) Bug: 511980805,510287771 Change-Id: I97295095fa9d7491ac195a12c0fec417a7cc377e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7835296 Auto-Submit: chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Original change's description: > Update translations > > Fixed: 511043924 > Change-Id: Ibd1dbfbaa55a77911dea397dfd5a2fb9cfa0a92f > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7829010 > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Auto-Submit: Philip Pfaffe <pfaffe@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> (cherry picked from commit af41ced) Bug: 512003527,511043924 Change-Id: Ibd1dbfbaa55a77911dea397dfd5a2fb9cfa0a92f Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7843252 Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Original change's description: > Migrate CSS hints to lit > > Fixed: 513741492 > Change-Id: Ib33754d6c64d962f89bd50c41017d932834b8002 > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7859679 > Reviewed-by: Simon Zünd <szuend@chromium.org> > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> (cherry picked from commit 4d18469) Bug: 515276175,513741492 Change-Id: Ib33754d6c64d962f89bd50c41017d932834b8002 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7867890 Auto-Submit: chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Original change's description: > Don't use innerHTML on user controlled data > > The data is coming from untrusted source, so we should not > render the HTML parts. > > Fixed: 513758833 > Change-Id: I5c2d755ab29bc75da09b420f3df695a6dc6a880c > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7856912 > Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org> > Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org> > Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> (cherry picked from commit 22f74fb) Bug: 514928864,513758833 Change-Id: I5c2d755ab29bc75da09b420f3df695a6dc6a880c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7868746 Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Change-Id: I67691193fa8c98c989f1fadfd050a1aacdb41aee Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7871080 Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Matthias Rohmer <mrohmer@google.com> (cherry picked from commit 6e72970) Bug: 516739855 Change-Id: I67691193fa8c98c989f1fadfd050a1aacdb41aee Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7871081 Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Matthias Rohmer <mrohmer@google.com> Reviewed-by: Mathias Bynens <mathias@chromium.org>
Original change's description: > Fix inline editing > > Fixed: 515639787 > Change-Id: I5a2ba54c1ebffb5d7171fa1033bbc3db00ecc110 > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7867644 > Auto-Submit: Alex Rudenko <alexrudenko@chromium.org> > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> > Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org> (cherry picked from commit e9ce152) Bug: 515679965,515639787 Change-Id: I5a2ba54c1ebffb5d7171fa1033bbc3db00ecc110 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7879746 Auto-Submit: chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs the
react-native-devtools-frontendfork with the upstreamchromium/7827branch (most recent stable from https://chromiumdash.appspot.com/branches).There were a total of ~171 conflicts. The ~80 translated
core/i18n/locales/*.jsonfiles were taken from upstream (generated artifacts, no RN strings). The remaining source conflicts were resolved as below.Notable resolutions
Experiments (
ExperimentNamerefactor)ExperimentNamefromcore/root/Runtime.tsinto a newcore/root/ExperimentNames.ts. We re-export it fromRuntime.tsso the fork's pervasiveRoot.Runtime.ExperimentName.*references keep resolving, add the React Native experiments toExperimentNames.ts, and register them for tests in upstream's newtesting/RuntimeHelpers.ts.RNExperimentName/ConditionNamestay inRuntime.ts.Rollup build (⚠️ build-strategy change)
@rollup/wasm-nodewith nativerollup, with platform binaries synced from cipd (infra/3pp/tools/rollup_libs) via a newDEPSentry +sync_rollup_libsgclient hook. Adopted the upstream native-rollup approach (per maintainer decision).gclient syncprovides the binaries.rehydrated_devtools_appentrypoint (entrypoints/rehydrated_devtools_app/in favour of its newtrace_app. The RN debugger opensrehydrated_devtools_app.htmlby name, so the entrypoint was restored (kept alongside upstream'strace_app). The rehydrating connection accepts both viaisTraceApp() || getPathName().includes('rehydrated_devtools_app').Content Security Policy
'unsafe-eval'(required by the React DevTools panels and consumed by thern_fuseboxworker-srcinjection ingenerate_html_entrypoint.js), reverting upstream's stricter multi-line CSP — consistent with prior syncs.Connection layer
Connection→ConnectionTransport/WebSocketConnection→WebSocketTransport/RehydratingConnection→RehydratingConnectionTransportrenames and the newTraceObject-based hydration flow, while preserving the fork's richerconnectionLostDetails({reason, code, errorType}) callback used byRemoteDebuggingTerminatedScreenand the hosted-mode WebSocket URL handling.Removed/renamed upstream APIs (re-applied in RN files)
UI.XLink/<x-link>removed →<devtools-link>(UI kit);UIUtils.createInlineButtonremoved → inlined;i18n.getFormatLocalizedString→ui/i18n;SimpleView/VBoxoptions-object constructors;Trace.Handlers.Types.ParsedTrace→Trace.TraceModel.ParsedTrace(handler data now under.data);*.css.jsimports are brandedCSSInJSstrings (dropped.cssText);getRegisteredViewExtensionsis now aViewManagerinstance method;UserMetrics.panelShownInLocationremoved upstream (no callers).Other necessary changes
RNPerfMetricsclass (TypeScript 6.0TS4094on the re-exported singleton).check-license-headerESLint rule to ESM (the rules dir is now ESM).BUILD.gndeps (ui/components/adorners,ui/components/icon_button,ui/kit) and a droppedRootimport inNetworkLogView.ts; converted lantern metric testit()callbacks tofunction()sothisis the Mocha context.nanoid/serialize-javascript/wsdependency overrides (superseded by upstream's newer tree).no-lit-render-outside-of-view/no-imperative-dom-api/no-adopted-style-sheetslint rules pending a proper view-function migration.UserActionRow.test.ts,application/components/StackTrace.ts,elements/components/LayoutPane.ts, ande2e/issues/client-hint-issues_test.ts(fork changes there were incidental formatting / a disabled test).Test plan
npm run prebuild && npm run build(gn gen + ninja + tsc) completes cleanly;rn_fusebox.html,rehydrated_devtools_app.html, andinspector.htmlentrypoints generate, with the expectedrn_fuseboxCSP ('unsafe-eval'+worker-src 'self' blob:).npm run lint -- --fix=falseon the changed files reports no problems.Smoke test on
rn_fusebox.html(to complete before merge) — using the plan from #172:Console
Sources
Performance
Memory (Heap snapshot, Allocation timeline)
React Components
React Profiler
This change maintains backwards compatibility with previous Local Storage data (settings/experiments/persisted client state).
Upstreaming plan
devtools-frontendrepo.