feat: add labels for social icons in mobile menu#1871
Conversation
|
@Astha-coder-web is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
github-actions
Bot
added
in-review
github-actions
Bot
added
Enhacement
|
✅ Synchronized metadata from Issue #1538:
|
iitzIrFan
left a comment
iitzIrFan
left a comment
There was a problem hiding this comment.
I think the UI needs some more tweeks! Need to align them horizntally
| .menu--responsive, | ||
| div[class*='sidebarViewport_'] { | ||
| z-index: 9999 !important; | ||
| } | ||
|
|
||
| .mobile-social-text { | ||
| margin-left: 8px; | ||
| } | ||
|
|
||
| @media (min-width: 997px) { | ||
| .mobile-social-text { | ||
| display: none; | ||
| } | ||
| } |
|
✅ Synchronized metadata from Issue #1538:
|
|
Hi @sanjay-kv, @Adez017 I've resolved the merge conflicts and updated the PR. Please review when you get a chance. Thank you! |
There was a problem hiding this comment.
Pull request overview
This PR improves the mobile hamburger menu UX by adding visible text labels next to the existing GitHub and Discord social icons, while keeping the desktop navbar appearance unchanged.
Changes:
- Added “GitHub” and “Discord” text labels beside the corresponding social icons in the navbar HTML.
- Introduced a
.mobile-social-textCSS class and responsive rule intended to show labels on mobile only.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/css/custom.css | Adds .mobile-social-text styling and a desktop breakpoint rule to hide labels (currently missing a closing brace). |
| docusaurus.config.ts | Adds <span class="mobile-social-text">…</span> labels to the GitHub/Discord navbar HTML items. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .mobile-social-text { | ||
| display: none; | ||
| } | ||
|
|
There was a problem hiding this comment.
@Astha-coder-web make changes and o verify before tagging maintainers plz!
Description
Added text labels for GitHub and Discord social icons in the mobile hamburger menu to improve navigation and clarity on mobile devices.
Changes Made
Fixes #1538
