feat: add TanStack Start SolidJS example#470
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d27456398
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Adds a new TanStack Start + SolidJS example under rsbuild/, while also aligning existing TanStack Start examples’ TypeScript configs to include @rsbuild/core/client types for Rsbuild client globals.
Changes:
- Add new
rsbuild/tanstack-start-solidexample app (routes, router setup, Rsbuild config, assets, docs). - Update TanStack Start (React) and TanStack Start (RSC)
tsconfig.jsonto include@rsbuild/core/clientintypes. - Update workspace lockfile for the new example’s dependencies.
Reviewed changes
Copilot reviewed 16 out of 20 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| rsbuild/tanstack-start/tsconfig.json | Adds @rsbuild/core/client to TS types for Rsbuild client typings. |
| rsbuild/tanstack-start-rsc/tsconfig.json | Adds @rsbuild/core/client to TS types for Rsbuild client typings. |
| rsbuild/tanstack-start-solid/tsconfig.json | New Solid Start example TS config (bundler mode + strict linting flags). |
| rsbuild/tanstack-start-solid/src/styles.css | New example styling (Tailwind import + custom tokens/animations). |
| rsbuild/tanstack-start-solid/src/routeTree.gen.ts | Generated TanStack Router route tree for file-based routing. |
| rsbuild/tanstack-start-solid/src/routes/index.tsx | New home route UI for the Solid Start example. |
| rsbuild/tanstack-start-solid/src/routes/about.tsx | New about route UI for the Solid Start example. |
| rsbuild/tanstack-start-solid/src/routes/__root.tsx | Root document shell wiring (HeadContent/Outlet/Scripts, global CSS link). |
| rsbuild/tanstack-start-solid/src/router.tsx | Router creation and @tanstack/solid-router type registration. |
| rsbuild/tanstack-start-solid/src/components/Header.tsx | Example header navigation using TanStack Router Link. |
| rsbuild/tanstack-start-solid/rsbuild.config.ts | Rsbuild pipeline for Solid + Tailwind + TanStack Start plugin. |
| rsbuild/tanstack-start-solid/README.md | New example README with run/build instructions and links. |
| rsbuild/tanstack-start-solid/public/robots.txt | Basic robots configuration for the example. |
| rsbuild/tanstack-start-solid/public/manifest.json | Web app manifest (icons, theme/background colors). |
| rsbuild/tanstack-start-solid/package.json | New example package metadata, scripts, and dependencies. |
| rsbuild/tanstack-start-solid/.gitignore | Ignore build outputs and TanStack/Vinxi-related directories for the example. |
| pnpm-lock.yaml | Adds importer + resolved dependency graph for the new example. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15d6c44aab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Adds a basic TanStack Start SolidJS example